Issue 15547002: Compile fix for ENABLE_CSS_DEVICE_ADAPTATION.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15547002: Compile fix for ENABLE_CSS_DEVICE_ADAPTATION. (Closed)

Created:
7 years, 7 months ago by rune

Modified:
7 years, 7 months ago

Reviewers:
aelias_OOO_until_Jul13, abarth-chromium

CC:
blink-reviews, apavlov+blink_chromium.org, dglazkov+blink, eae+blinkwatch, kenneth.christiansen, darktears

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Compile fix for ENABLE_CSS_DEVICE_ADAPTATION. Orientation was removed from ViewportArguments in r150743. Setting orientation from the @viewport descriptor was still left. Removed that to make blink compile with @viewport support. BUG=NONE

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	Source/core/css/resolver/ViewportStyleResolver.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

aelias_OOO_until_Jul13

7 years, 7 months ago (2013-05-21 18:56:44 UTC) #3

r150743 got reverted anyway, so you don't need to land this to fix the build.  I
wasn't aware of the "orientation" value in @viewport spec, I assumed it was an
unused relic of some kind.  I'll bring the value back in the next iteration of
https://chromiumcodereview.appspot.com/14813025/

Expand Messages | Collapse Messages