Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2021)

Issue 1554693002: Move webview_framework_jar to config.gni (Closed)

Created:
4 years, 11 months ago by michaelbai
Modified:
4 years, 11 months ago
Reviewers:
agrieve
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move webview_framework_jar to config.gni As the counterpart of android_sdk_jar, move webview_framework_jar to config.gni, so it is easy to be overriden in downstream. BUG=565532 Committed: https://crrev.com/d66326c14bb70a1d61d75b096a9a344bc9a53c1a Cr-Commit-Position: refs/heads/master@{#367167}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M android_webview/glue/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M build/config/android/config.gni View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
michaelbai
4 years, 11 months ago (2015-12-30 02:44:48 UTC) #3
agrieve
On 2015/12/30 02:44:48, michaelbai wrote: lgtm
4 years, 11 months ago (2015-12-30 15:03:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1554693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1554693002/1
4 years, 11 months ago (2015-12-30 18:16:19 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-30 18:59:18 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2015-12-30 18:59:56 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d66326c14bb70a1d61d75b096a9a344bc9a53c1a
Cr-Commit-Position: refs/heads/master@{#367167}

Powered by Google App Engine
This is Rietveld 408576698