Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Unified Diff: lib/src/compiler.dart

Issue 1554683002: Update to latest analyzer (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/src/compiler.dart
diff --git a/lib/src/compiler.dart b/lib/src/compiler.dart
index acf5494ed5505fdecc2413c79a29819afe8650d5..e20f6f85f109d543cc16660f774685e777315932 100644
--- a/lib/src/compiler.dart
+++ b/lib/src/compiler.dart
@@ -189,7 +189,9 @@ class BatchCompiler extends AbstractCompiler {
bool _compileLibrary(LibraryElement library, CompilationNotifier notifier) {
var success = _compilationRecord[library];
if (success != null) {
- if (!success) _failure = true;
+ if (!success) {
+ _failure = true;
+ }
return success;
}
@@ -250,7 +252,9 @@ class BatchCompiler extends AbstractCompiler {
}
// Return tentative success status.
- if (!success) _failure = true;
+ if (!success) {
+ _failure = true;
+ }
return success;
}
@@ -459,7 +463,7 @@ abstract class AbstractCompiler {
// TODO(jmesserly): for now, treat DDC errors as having a different
// error level from Analayzer ones.
- if (error.errorCode.name.startsWith('dev_compiler')) {
+ if (error.errorCode.name.startsWith('STRONG_MODE')) {
reporter.onError(error);
if (error.errorCode.errorSeverity == ErrorSeverity.ERROR) {
failure = true;

Powered by Google App Engine
This is Rietveld 408576698