[Media Router] First Run Flow WebUI and strings.

[Media Router] First Run Flow WebUI and strings.

Part 1 of several. This is currently set up to be landed as a standalone part of the first run flow work.

This change includes:
- Add strings for Chromium specific first run flow.
- Add first run flow nux to the WebUI (but stay unstamped for now). Used redlines and mocks as guidelines.

BUG=560457
Committed: https://crrev.com/1ba8e69049df4f72650ed19058d062690dcee5d3
Cr-Commit-Position: refs/heads/master@{#367221}

[apacible, 2015-12-29 22:33:54]

Patchset #1 (id:1) has been deleted

[apacible, 2015-12-29 23:02:22]

Patchset #1 (id:20001) has been deleted

[apacible, 2015-12-29 23:12:10]

Description was changed from

==========
nux scaffolding

BUG=
==========

to

==========
[Media Router] First Run Flow WebUI and strings.

Part 1 of several.

This change includes:
- Add strings for Chromium specific first run flow.
- Add first run flow nux to the WebUI (but stay unstamped for now). Used
redlines and mocks as guidelines.

This is currently set up to be landed independently. After later parts of this
work is landed, there will be some optimization work done, such as not sending
unnecessary data (e.g. strings) to the WebUI if we're not showing the nux.

BUG=560457
==========

[apacible, 2015-12-29 23:12:10]

apacible@chromium.org changed reviewers:
+ imcheng@chromium.org

[apacible, 2015-12-29 23:31:43]

Description was changed from

==========
[Media Router] First Run Flow WebUI and strings.

Part 1 of several.

This change includes:
- Add strings for Chromium specific first run flow.
- Add first run flow nux to the WebUI (but stay unstamped for now). Used
redlines and mocks as guidelines.

This is currently set up to be landed independently. After later parts of this
work is landed, there will be some optimization work done, such as not sending
unnecessary data (e.g. strings) to the WebUI if we're not showing the nux.

BUG=560457
==========

to

==========
[Media Router] First Run Flow WebUI and strings.

Part 1 of several.

This change includes:
- Add strings for Chromium specific first run flow.
- Add first run flow nux to the WebUI (but stay unstamped for now). Used
redlines and mocks as guidelines.

This is currently set up to be landed as a standalone part of the first run flow
work. After later parts of this work is landed, there will be some optimization
work done, such as not sending unnecessary data (e.g. strings) to the WebUI if
we're not showing the nux.

BUG=560457
==========

[apacible, 2015-12-29 23:38:27]

Patchset #1 (id:40001) has been deleted

[apacible, 2015-12-29 23:48:22]

Description was changed from

==========
[Media Router] First Run Flow WebUI and strings.

Part 1 of several.

This change includes:
- Add strings for Chromium specific first run flow.
- Add first run flow nux to the WebUI (but stay unstamped for now). Used
redlines and mocks as guidelines.

This is currently set up to be landed as a standalone part of the first run flow
work. After later parts of this work is landed, there will be some optimization
work done, such as not sending unnecessary data (e.g. strings) to the WebUI if
we're not showing the nux.

BUG=560457
==========

to

==========
[Media Router] First Run Flow WebUI and strings.

Part 1 of several.

This change includes:
- Add strings for Chromium specific first run flow.
- Add first run flow nux to the WebUI (but stay unstamped for now). Used
redlines and mocks as guidelines.

This is currently set up to be landed as a standalone part of the first run flow
work. After later parts of this work is landed, there will be some optimization
work done, such as only sending first run flow specific data (e.g. strings) to
the WebUI if we're showing the nux.

BUG=560457
==========

[apacible, 2015-12-29 23:49:20]

Description was changed from

==========
[Media Router] First Run Flow WebUI and strings.

Part 1 of several.

This change includes:
- Add strings for Chromium specific first run flow.
- Add first run flow nux to the WebUI (but stay unstamped for now). Used
redlines and mocks as guidelines.

This is currently set up to be landed as a standalone part of the first run flow
work. After later parts of this work is landed, there will be some optimization
work done, such as only sending first run flow specific data (e.g. strings) to
the WebUI if we're showing the nux.

BUG=560457
==========

to

==========
[Media Router] First Run Flow WebUI and strings.

Part 1 of several. This is currently set up to be landed as a standalone part of
the first run flow work.

This change includes:
- Add strings for Chromium specific first run flow.
- Add first run flow nux to the WebUI (but stay unstamped for now). Used
redlines and mocks as guidelines.

BUG=560457
==========

[apacible, 2015-12-29 23:54:28]

PTAL, thanks!

Screenshots:
LTR: https://screenshot.googleplex.com/X2d29XuObnz.png
RTL: https://screenshot.googleplex.com/cHJYObqOL8O.png

Some notes:
- The changes are currently hidden (not stamped), so there are no visible
changes right now. 
- A couple changes will be need to be made for Chrome specifically (strings,
cloud services opt in).
- Clean up and optimizations will be made in the future when end to end work for
the first run flow is finished.

[imcheng, 2015-12-30 18:48:59]

lgtm

Looks good. Just a comment about the messages. Look forward to seeing the
browser side patch.

https://codereview.chromium.org/1554663002/diff/60001/chrome/app/media_router...
File chrome/app/media_router_strings.grdp (right):

https://codereview.chromium.org/1554663002/diff/60001/chrome/app/media_router...
chrome/app/media_router_strings.grdp:53: Welcome to the Cast experience in
Chromium!
This will have to say "... in Google Chrome!" for official builds. I think what
that means is you will have to extract this Chromium message, define a separate
message for Google Chrome, then include it in chrome/app/chromium_strings.grd /
google_chrome_strings.grd respectively. Alternatively, we can just get rid of
the "in Chromium!" part, but do check with UX....

https://codereview.chromium.org/1554663002/diff/60001/chrome/test/data/webui/...
File chrome/test/data/webui/media_router/media_router_container_tests.js
(right):

https://codereview.chromium.org/1554663002/diff/60001/chrome/test/data/webui/...
chrome/test/data/webui/media_router/media_router_container_tests.js:169:
container.addEventListener('acknowledge-first-run-flow', function() {
You can just pass in 'done' as the 2nd arg.

[apacible, 2015-12-31 00:38:03]

https://codereview.chromium.org/1554663002/diff/60001/chrome/app/media_router...
File chrome/app/media_router_strings.grdp (right):

https://codereview.chromium.org/1554663002/diff/60001/chrome/app/media_router...
chrome/app/media_router_strings.grdp:53: Welcome to the Cast experience in
Chromium!
On 2015/12/30 18:48:59, imcheng1 wrote:
> This will have to say "... in Google Chrome!" for official builds. I think
what
> that means is you will have to extract this Chromium message, define a
separate
> message for Google Chrome, then include it in chrome/app/chromium_strings.grd
/
> google_chrome_strings.grd respectively. Alternatively, we can just get rid of
> the "in Chromium!" part, but do check with UX....

Hm, okay. I was going to redefine the string in Chrome. Privacy/UX may revisit
the strings before giving the final OK, so I'll keep this as is and update them
later. I'll check with UX on the "in Chromium!" part.

https://codereview.chromium.org/1554663002/diff/60001/chrome/test/data/webui/...
File chrome/test/data/webui/media_router/media_router_container_tests.js
(right):

https://codereview.chromium.org/1554663002/diff/60001/chrome/test/data/webui/...
chrome/test/data/webui/media_router/media_router_container_tests.js:169:
container.addEventListener('acknowledge-first-run-flow', function() {
On 2015/12/30 18:48:59, imcheng1 wrote:
> You can just pass in 'done' as the 2nd arg.

Passing the function directly in as an arg invokes it when L169 is called.

[apacible, 2015-12-31 00:40:20]

The CQ bit was checked by apacible@chromium.org

[apacible, 2015-12-31 00:40:20]

The patchset sent to the CQ was uploaded after l-g-t-m from imcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/1554663002/#ps100001
(title: " ")

[commit-bot: I haz the power, 2015-12-31 00:40:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1554663002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1554663002/100001

[commit-bot: I haz the power, 2015-12-31 02:10:33]

Description was changed from

==========
[Media Router] First Run Flow WebUI and strings.

Part 1 of several. This is currently set up to be landed as a standalone part of
the first run flow work.

This change includes:
- Add strings for Chromium specific first run flow.
- Add first run flow nux to the WebUI (but stay unstamped for now). Used
redlines and mocks as guidelines.

BUG=560457
==========

to

==========
[Media Router] First Run Flow WebUI and strings.

Part 1 of several. This is currently set up to be landed as a standalone part of
the first run flow work.

This change includes:
- Add strings for Chromium specific first run flow.
- Add first run flow nux to the WebUI (but stay unstamped for now). Used
redlines and mocks as guidelines.

BUG=560457
==========

[commit-bot: I haz the power, 2015-12-31 02:10:33]

Committed patchset #3 (id:100001)

[commit-bot: I haz the power, 2015-12-31 02:11:36]

Description was changed from

==========
[Media Router] First Run Flow WebUI and strings.

Part 1 of several. This is currently set up to be landed as a standalone part of
the first run flow work.

This change includes:
- Add strings for Chromium specific first run flow.
- Add first run flow nux to the WebUI (but stay unstamped for now). Used
redlines and mocks as guidelines.

BUG=560457
==========

to

==========
[Media Router] First Run Flow WebUI and strings.

Part 1 of several. This is currently set up to be landed as a standalone part of
the first run flow work.

This change includes:
- Add strings for Chromium specific first run flow.
- Add first run flow nux to the WebUI (but stay unstamped for now). Used
redlines and mocks as guidelines.

BUG=560457

Committed: https://crrev.com/1ba8e69049df4f72650ed19058d062690dcee5d3
Cr-Commit-Position: refs/heads/master@{#367221}
==========

[commit-bot: I haz the power, 2015-12-31 02:11:36]

Patchset 3 (id:??) landed as
https://crrev.com/1ba8e69049df4f72650ed19058d062690dcee5d3
Cr-Commit-Position: refs/heads/master@{#367221}