Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1361)

Unified Diff: mojo/edk/system/raw_channel.cc

Issue 1554623005: Ensure that in-flight message pipes are always closed and the other end is notified. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix dcheck of lock being acquired at destruction Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/edk/system/message_pipe_dispatcher.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/system/raw_channel.cc
diff --git a/mojo/edk/system/raw_channel.cc b/mojo/edk/system/raw_channel.cc
index 34f0c1c7445c94b8673a12ab518124b65b6ec57b..5d0a04c47273dfddbfaa8c02f66bac8b4bd11205 100644
--- a/mojo/edk/system/raw_channel.cc
+++ b/mojo/edk/system/raw_channel.cc
@@ -649,7 +649,8 @@ void RawChannel::DispatchMessages(bool* did_dispatch_message,
return; // |this| may have been destroyed in |CallOnError()|.
}
- if (message_view.type() != MessageInTransit::Type::MESSAGE) {
+ if (message_view.type() != MessageInTransit::Type::MESSAGE &&
+ message_view.type() != MessageInTransit::Type::QUIT_MESSAGE) {
if (!OnReadMessageForRawChannel(message_view)) {
CallOnError(Delegate::ERROR_READ_BAD_MESSAGE);
*stop_dispatching = true;
« no previous file with comments | « mojo/edk/system/message_pipe_dispatcher.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698