Don't conflate Timeline serialized json with event type

Don't conflate Timeline serialized json with event type

- Makes event setup (event type, timestamps, etc) regular.
- Allows any event type to have pre-serialized JSON.

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/c580f7f393743761a9c9fdb65426e0b1b29fecf2

[Cutch, 2015-12-29 23:15:26]

Description was changed from

==========
Don't conflate preserialized json with event type

BUG=
==========

to

==========
Don't conflate Timeline serialized json with event type

- Makes event setup (event type, timestamps, etc) regular.
- Allows any event type to have pre-serialized JSON.
==========

[Cutch, 2015-12-29 23:15:26]

johnmccutchan@google.com changed reviewers:
+ asiva@google.com

[siva, 2015-12-30 20:21:26]

lgtm

https://codereview.chromium.org/1554623003/diff/1/runtime/lib/timeline.cc
File runtime/lib/timeline.cc (right):

https://codereview.chromium.org/1554623003/diff/1/runtime/lib/timeline.cc#new...
runtime/lib/timeline.cc:78: args.ToCString());
Can this json initialization stuff be moved down below the
'switch (phase_string[0]) { ... }'
statement? That way we won't be calling it for the case when
'if (event == NULL)'
is true.

I think this pattern exists in other calls too.

[Cutch, 2015-12-30 20:48:14]

https://codereview.chromium.org/1554623003/diff/1/runtime/lib/timeline.cc
File runtime/lib/timeline.cc (right):

https://codereview.chromium.org/1554623003/diff/1/runtime/lib/timeline.cc#new...
runtime/lib/timeline.cc:78: args.ToCString());
Good suggestion. Done here and elsewhere.

[Cutch, 2015-12-30 20:48:28]

Description was changed from

==========
Don't conflate Timeline serialized json with event type

- Makes event setup (event type, timestamps, etc) regular.
- Allows any event type to have pre-serialized JSON.
==========

to

==========
Don't conflate Timeline serialized json with event type

- Makes event setup (event type, timestamps, etc) regular.
- Allows any event type to have pre-serialized JSON.

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c580f7f393743761a9c9fdb65426e0b1b29fecf2
==========

[Cutch, 2015-12-30 20:48:29]

Committed patchset #2 (id:20001) manually as
c580f7f393743761a9c9fdb65426e0b1b29fecf2 (presubmit successful).