Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5258)

Unified Diff: chrome/browser/devtools/BUILD.gn

Issue 1554563002: Put more files under the enable_service_discovery build flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix typo Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | chrome/browser/devtools/device/devtools_android_bridge.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/BUILD.gn
diff --git a/chrome/browser/devtools/BUILD.gn b/chrome/browser/devtools/BUILD.gn
index 17b2789cd81673d85f54608dbebf13299d4a8991..2b603823c31e2adf3e6221d304e55ce1c84b1f1c 100644
--- a/chrome/browser/devtools/BUILD.gn
+++ b/chrome/browser/devtools/BUILD.gn
@@ -3,6 +3,7 @@
# found in the LICENSE file.
if (!is_android) {
+ import("//build/config/features.gni")
import("//tools/grit/grit_rule.gni")
}
@@ -93,8 +94,6 @@ static_library("devtools") {
"device/android_device_manager.cc",
"device/android_device_manager.h",
"device/android_web_socket.cc",
- "device/cast_device_provider.cc",
- "device/cast_device_provider.h",
"device/devtools_android_bridge.cc",
"device/devtools_android_bridge.h",
"device/port_forwarding_controller.cc",
@@ -109,14 +108,6 @@ static_library("devtools") {
"device/usb/android_usb_socket.h",
"device/usb/usb_device_provider.cc",
"device/usb/usb_device_provider.h",
- "device/webrtc/devtools_bridge_client.cc",
- "device/webrtc/devtools_bridge_client.h",
- "device/webrtc/devtools_bridge_instances_request.cc",
- "device/webrtc/devtools_bridge_instances_request.h",
- "device/webrtc/send_command_request.cc",
- "device/webrtc/send_command_request.h",
- "device/webrtc/webrtc_device_provider.cc",
- "device/webrtc/webrtc_device_provider.h",
"devtools_contents_resizing_strategy.cc",
"devtools_contents_resizing_strategy.h",
"devtools_embedder_message_dispatcher.cc",
@@ -142,6 +133,20 @@ static_library("devtools") {
"remote_debugging_server.cc",
"remote_debugging_server.h",
]
+ if (enable_service_discovery) {
Vitaly Buka (NO REVIEWS) 2016/01/04 23:10:46 I guess it's always enabled on platforms with devt
+ sources += [
+ "device/cast_device_provider.cc",
+ "device/cast_device_provider.h",
+ "device/webrtc/devtools_bridge_client.cc",
+ "device/webrtc/devtools_bridge_client.h",
Vitaly Buka (NO REVIEWS) 2016/01/04 23:10:46 Some of these files depend on gcd_api_flow.cc only
+ "device/webrtc/devtools_bridge_instances_request.cc",
+ "device/webrtc/devtools_bridge_instances_request.h",
+ "device/webrtc/send_command_request.cc",
Vitaly Buka (NO REVIEWS) 2016/01/05 01:18:13 Actually this code is obsolete and going away: htt
Lei Zhang 2016/01/05 02:36:10 I'll wait for that to land and see what we end up
+ "device/webrtc/send_command_request.h",
+ "device/webrtc/webrtc_device_provider.cc",
+ "device/webrtc/webrtc_device_provider.h",
+ ]
+ }
}
}
« no previous file with comments | « build/common.gypi ('k') | chrome/browser/devtools/device/devtools_android_bridge.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698