content/common/gpu/media/v4l2_slice_video_decode_accelerator.cc - Issue 1554543002: v4l2 accelerators: use V4L2_CAP_VIDEO_M2M_MPLANE capability.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/v4l2_slice_video_decode_accelerator.cc

Issue 1554543002: v4l2 accelerators: use V4L2_CAP_VIDEO_M2M_MPLANE capability. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove fallback in slice VDA and image processor Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/gpu/media/v4l2_image_processor.cc ('k') | content/common/gpu/media/v4l2_video_decode_accelerator.cc » ('j') | content/common/gpu/media/v4l2_video_decode_accelerator.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/media/v4l2_slice_video_decode_accelerator.cc

diff --git a/content/common/gpu/media/v4l2_slice_video_decode_accelerator.cc b/content/common/gpu/media/v4l2_slice_video_decode_accelerator.cc

index f17dc6295cb4ab44e3f8be2c9a8648d048365648..22185210d1edb619691fc2d533e9aa749fa945be 100644

--- a/content/common/gpu/media/v4l2_slice_video_decode_accelerator.cc

+++ b/content/common/gpu/media/v4l2_slice_video_decode_accelerator.cc

@@ -485,14 +485,11 @@ bool V4L2SliceVideoDecodeAccelerator::Initialize(const Config& config,

// Capabilities check.

struct v4l2_capability caps;

- const __u32 kCapsRequired =

- V4L2_CAP_VIDEO_CAPTURE_MPLANE |

- V4L2_CAP_VIDEO_OUTPUT_MPLANE |

- V4L2_CAP_STREAMING;

+ const __u32 kCapsRequired = V4L2_CAP_VIDEO_M2M_MPLANE | V4L2_CAP_STREAMING;

IOCTL_OR_ERROR_RETURN_FALSE(VIDIOC_QUERYCAP, &caps);

if ((caps.capabilities & kCapsRequired) != kCapsRequired) {

- DLOG(ERROR) << "Initialize(): ioctl() failed: VIDIOC_QUERYCAP"

- ", caps check failed: 0x" << std::hex << caps.capabilities;

+ LOG(ERROR) << "Initialize(): ioctl() failed: VIDIOC_QUERYCAP"

wuchengli 2015/12/29 09:43:32 I don't know why this used to be DLOG. All other t

+ ", caps check failed: 0x" << std::hex << caps.capabilities;

return false;

}