v4l2 accelerators: use V4L2_CAP_VIDEO_M2M_MPLANE capability.

v4l2 accelerators: use V4L2_CAP_VIDEO_M2M_MPLANE capability.

The correct capability for v4l2 devices should be V4L2_CAP_VIDEO_M2M_MPLANE.
V4L2_CAP_VIDEO_CAPTURE_MPLANE and V4L2_CAP_VIDEO_OUTPUT_MPLANE will be
deprecated. Nyan doesn't report V4L2_CAP_VIDEO_M2M_MPLANE yet. So check
both capabilities in V4L2VDA and V4L2VEA.

BUG=chromium:572132
TEST=Run tests on nyan, peach, and veyron.

Committed: https://crrev.com/287a3f60e9502553489dc1b983c90e040c7dc445
Cr-Commit-Position: refs/heads/master@{#367061}

[wuchengli, 2015-12-29 09:41:57]

Description was changed from

==========
v4l2 accelerators: use V4L2_CAP_VIDEO_M2M_MPLANE capability.

The correct capability for v4l2 devices should be V4L2_CAP_VIDEO_M2M_MPLANE.
V4L2_CAP_VIDEO_CAPTURE_MPLANE and V4L2_CAP_VIDEO_OUTPUT_MPLANE will be
deprecated. Before nyan supports V4L2_CAP_VIDEO_M2M_MPLANE, check both
capabilities.

BUG=chromium:572132
TEST=Run tests on nyan, peach, and veyron.
==========

to

==========
v4l2 accelerators: use V4L2_CAP_VIDEO_M2M_MPLANE capability.

The correct capability for v4l2 devices should be V4L2_CAP_VIDEO_M2M_MPLANE.
V4L2_CAP_VIDEO_CAPTURE_MPLANE and V4L2_CAP_VIDEO_OUTPUT_MPLANE will be
deprecated. Nyan doesn't report V4L2_CAP_VIDEO_M2M_MPLANE yet. So check
both capabilities in V4L2VDA and V4L2VEA.

BUG=chromium:572132
TEST=Run tests on nyan, peach, and veyron.
==========

[wuchengli, 2015-12-29 09:43:21]

wuchengli@chromium.org changed reviewers:
+ kcwu@chromium.org, posciak@chromium.org

[wuchengli, 2015-12-29 09:43:32]

PTAL.

https://codereview.chromium.org/1554543002/diff/20001/content/common/gpu/medi...
File content/common/gpu/media/v4l2_slice_video_decode_accelerator.cc (right):

https://codereview.chromium.org/1554543002/diff/20001/content/common/gpu/medi...
content/common/gpu/media/v4l2_slice_video_decode_accelerator.cc:491: LOG(ERROR)
<< "Initialize(): ioctl() failed: VIDIOC_QUERYCAP"
I don't know why this used to be DLOG. All other three files are LOG(ERROR).

[Pawel Osciak, 2015-12-29 10:07:47]

lgtm % nit

https://codereview.chromium.org/1554543002/diff/20001/content/common/gpu/medi...
File content/common/gpu/media/v4l2_video_decode_accelerator.cc (right):

https://codereview.chromium.org/1554543002/diff/20001/content/common/gpu/medi...
content/common/gpu/media/v4l2_video_decode_accelerator.cc:262: const __u32
kCapsRequiredCompat = V4L2_CAP_VIDEO_CAPTURE_MPLANE |
Please add a short comment here and in VEA that this cap combination is
deprecated, but some older drivers may still be returning it.

[wuchengli, 2015-12-29 11:28:08]

https://codereview.chromium.org/1554543002/diff/20001/content/common/gpu/medi...
File content/common/gpu/media/v4l2_video_decode_accelerator.cc (right):

https://codereview.chromium.org/1554543002/diff/20001/content/common/gpu/medi...
content/common/gpu/media/v4l2_video_decode_accelerator.cc:262: const __u32
kCapsRequiredCompat = V4L2_CAP_VIDEO_CAPTURE_MPLANE |
On 2015/12/29 10:07:47, Pawel Osciak wrote:
> Please add a short comment here and in VEA that this cap combination is
> deprecated, but some older drivers may still be returning it.

Done.

[wuchengli, 2015-12-29 11:28:24]

The CQ bit was checked by wuchengli@chromium.org

[wuchengli, 2015-12-29 11:28:24]

The patchset sent to the CQ was uploaded after l-g-t-m from posciak@chromium.org
Link to the patchset: https://codereview.chromium.org/1554543002/#ps40001
(title: "add comment")

[commit-bot: I haz the power, 2015-12-29 11:28:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1554543002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1554543002/40001

[commit-bot: I haz the power, 2015-12-29 11:43:07]

Description was changed from

==========
v4l2 accelerators: use V4L2_CAP_VIDEO_M2M_MPLANE capability.

The correct capability for v4l2 devices should be V4L2_CAP_VIDEO_M2M_MPLANE.
V4L2_CAP_VIDEO_CAPTURE_MPLANE and V4L2_CAP_VIDEO_OUTPUT_MPLANE will be
deprecated. Nyan doesn't report V4L2_CAP_VIDEO_M2M_MPLANE yet. So check
both capabilities in V4L2VDA and V4L2VEA.

BUG=chromium:572132
TEST=Run tests on nyan, peach, and veyron.
==========

to

==========
v4l2 accelerators: use V4L2_CAP_VIDEO_M2M_MPLANE capability.

The correct capability for v4l2 devices should be V4L2_CAP_VIDEO_M2M_MPLANE.
V4L2_CAP_VIDEO_CAPTURE_MPLANE and V4L2_CAP_VIDEO_OUTPUT_MPLANE will be
deprecated. Nyan doesn't report V4L2_CAP_VIDEO_M2M_MPLANE yet. So check
both capabilities in V4L2VDA and V4L2VEA.

BUG=chromium:572132
TEST=Run tests on nyan, peach, and veyron.
==========

[commit-bot: I haz the power, 2015-12-29 11:43:08]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-29 11:43:55]

Description was changed from

==========
v4l2 accelerators: use V4L2_CAP_VIDEO_M2M_MPLANE capability.

The correct capability for v4l2 devices should be V4L2_CAP_VIDEO_M2M_MPLANE.
V4L2_CAP_VIDEO_CAPTURE_MPLANE and V4L2_CAP_VIDEO_OUTPUT_MPLANE will be
deprecated. Nyan doesn't report V4L2_CAP_VIDEO_M2M_MPLANE yet. So check
both capabilities in V4L2VDA and V4L2VEA.

BUG=chromium:572132
TEST=Run tests on nyan, peach, and veyron.
==========

to

==========
v4l2 accelerators: use V4L2_CAP_VIDEO_M2M_MPLANE capability.

The correct capability for v4l2 devices should be V4L2_CAP_VIDEO_M2M_MPLANE.
V4L2_CAP_VIDEO_CAPTURE_MPLANE and V4L2_CAP_VIDEO_OUTPUT_MPLANE will be
deprecated. Nyan doesn't report V4L2_CAP_VIDEO_M2M_MPLANE yet. So check
both capabilities in V4L2VDA and V4L2VEA.

BUG=chromium:572132
TEST=Run tests on nyan, peach, and veyron.

Committed: https://crrev.com/287a3f60e9502553489dc1b983c90e040c7dc445
Cr-Commit-Position: refs/heads/master@{#367061}
==========

[commit-bot: I haz the power, 2015-12-29 11:43:56]

Patchset 3 (id:??) landed as
https://crrev.com/287a3f60e9502553489dc1b983c90e040c7dc445
Cr-Commit-Position: refs/heads/master@{#367061}