Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: pdf/preview_mode_client.h

Issue 1554533002: Mark methods with override in pdf/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add Clang plugin flag correctly Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pdf/pdfium/pdfium_engine.cc ('k') | tools/clang/plugins/ChromeClassTester.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pdf/preview_mode_client.h
diff --git a/pdf/preview_mode_client.h b/pdf/preview_mode_client.h
index 1f424a76bf442323d0b60c95593f929a75f47fe6..0127db9a3a59d6cdde4615473bdbc5d897f9d14d 100644
--- a/pdf/preview_mode_client.h
+++ b/pdf/preview_mode_client.h
@@ -22,57 +22,57 @@ class PreviewModeClient : public PDFEngine::Client {
virtual void PreviewDocumentLoadFailed() = 0;
virtual void PreviewDocumentLoadComplete() = 0;
};
+
explicit PreviewModeClient(Client* client);
- virtual ~PreviewModeClient() {}
+ ~PreviewModeClient() override {}
// PDFEngine::Client implementation.
- virtual void DocumentSizeUpdated(const pp::Size& size);
- virtual void Invalidate(const pp::Rect& rect);
- virtual void Scroll(const pp::Point& point);
- virtual void ScrollToX(int position);
- virtual void ScrollToY(int position);
- virtual void ScrollToPage(int page);
- virtual void NavigateTo(const std::string& url, bool open_in_new_tab);
- virtual void UpdateCursor(PP_CursorType_Dev cursor);
- virtual void UpdateTickMarks(const std::vector<pp::Rect>& tickmarks);
- virtual void NotifyNumberOfFindResultsChanged(int total,
- bool final_result);
- virtual void NotifySelectedFindResultChanged(int current_find_index);
- virtual void GetDocumentPassword(
- pp::CompletionCallbackWithOutput<pp::Var> callback);
- virtual void Alert(const std::string& message);
- virtual bool Confirm(const std::string& message);
- virtual std::string Prompt(const std::string& question,
- const std::string& default_answer);
- virtual std::string GetURL();
- virtual void Email(const std::string& to,
- const std::string& cc,
- const std::string& bcc,
- const std::string& subject,
- const std::string& body);
- virtual void Print();
- virtual void SubmitForm(const std::string& url,
- const void* data,
- int length);
- virtual std::string ShowFileSelectionDialog();
- virtual pp::URLLoader CreateURLLoader();
- virtual void ScheduleCallback(int id, int delay_in_ms);
- virtual void SearchString(const base::char16* string,
- const base::char16* term,
- bool case_sensitive,
- std::vector<SearchStringResult>* results);
- virtual void DocumentPaintOccurred();
- virtual void DocumentLoadComplete(int page_count);
- virtual void DocumentLoadFailed();
- virtual pp::Instance* GetPluginInstance();
- virtual void DocumentHasUnsupportedFeature(const std::string& feature);
- virtual void DocumentLoadProgress(uint32_t available, uint32_t doc_size);
- virtual void FormTextFieldFocusChange(bool in_focus);
- virtual bool IsPrintPreview();
- virtual uint32_t GetBackgroundColor();
+ void DocumentSizeUpdated(const pp::Size& size) override;
+ void Invalidate(const pp::Rect& rect) override;
+ void Scroll(const pp::Point& point) override;
+ void ScrollToX(int position) override;
+ void ScrollToY(int position) override;
+ void ScrollToPage(int page) override;
+ void NavigateTo(const std::string& url, bool open_in_new_tab) override;
+ void UpdateCursor(PP_CursorType_Dev cursor) override;
+ void UpdateTickMarks(const std::vector<pp::Rect>& tickmarks) override;
+ void NotifyNumberOfFindResultsChanged(int total, bool final_result) override;
+ void NotifySelectedFindResultChanged(int current_find_index) override;
+ void GetDocumentPassword(
+ pp::CompletionCallbackWithOutput<pp::Var> callback) override;
+ void Alert(const std::string& message) override;
+ bool Confirm(const std::string& message) override;
+ std::string Prompt(const std::string& question,
+ const std::string& default_answer) override;
+ std::string GetURL() override;
+ void Email(const std::string& to,
+ const std::string& cc,
+ const std::string& bcc,
+ const std::string& subject,
+ const std::string& body) override;
+ void Print() override;
+ void SubmitForm(const std::string& url,
+ const void* data,
+ int length) override;
+ std::string ShowFileSelectionDialog() override;
+ pp::URLLoader CreateURLLoader() override;
+ void ScheduleCallback(int id, int delay_in_ms) override;
+ void SearchString(const base::char16* string,
+ const base::char16* term,
+ bool case_sensitive,
+ std::vector<SearchStringResult>* results) override;
+ void DocumentPaintOccurred() override;
+ void DocumentLoadComplete(int page_count) override;
+ void DocumentLoadFailed() override;
+ pp::Instance* GetPluginInstance() override;
+ void DocumentHasUnsupportedFeature(const std::string& feature) override;
+ void DocumentLoadProgress(uint32_t available, uint32_t doc_size) override;
+ void FormTextFieldFocusChange(bool in_focus) override;
+ bool IsPrintPreview() override;
+ uint32_t GetBackgroundColor() override;
private:
- Client* client_;
+ Client* const client_;
};
} // namespace chrome_pdf
« no previous file with comments | « pdf/pdfium/pdfium_engine.cc ('k') | tools/clang/plugins/ChromeClassTester.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698