Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: pdf/pdf_engine.h

Issue 1554533002: Mark methods with override in pdf/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add Clang plugin flag correctly Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pdf/pdf.cc ('k') | pdf/pdfium/pdfium_engine.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pdf/pdf_engine.h
diff --git a/pdf/pdf_engine.h b/pdf/pdf_engine.h
index aa748750f1d56d926292cf63f8ce031c9d99a884..7df4bff21ead268b5686304588c8d58303538002 100644
--- a/pdf/pdf_engine.h
+++ b/pdf/pdf_engine.h
@@ -61,6 +61,8 @@ class PDFEngine {
// The interface that's provided to the rendering engine.
class Client {
public:
+ virtual ~Client() {}
+
// Informs the client about the document's size in pixels.
virtual void DocumentSizeUpdated(const pp::Size& size) = 0;
@@ -315,7 +317,8 @@ class PDFEngineExports {
PDFEngineExports() {}
virtual ~PDFEngineExports() {}
- static PDFEngineExports* Create();
+ static PDFEngineExports* Get();
+
#if defined(OS_WIN)
// See the definition of RenderPDFPageToDC in pdf.cc for details.
virtual bool RenderPDFPageToDC(const void* pdf_buffer,
« no previous file with comments | « pdf/pdf.cc ('k') | pdf/pdfium/pdfium_engine.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698