Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: tools/clang/plugins/ChromeClassTester.cpp

Issue 1554533002: Mark methods with override in pdf/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add Clang plugin flag correctly Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « pdf/preview_mode_client.h ('k') | tools/clang/plugins/FindBadConstructsAction.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // A general interface for filtering and only acting on classes in Chromium C++ 5 // A general interface for filtering and only acting on classes in Chromium C++
6 // code. 6 // code.
7 7
8 #include "ChromeClassTester.h" 8 #include "ChromeClassTester.h"
9 9
10 #include <algorithm> 10 #include <algorithm>
(...skipping 209 matching lines...) Expand 10 before | Expand all | Expand 10 after
220 } 220 }
221 221
222 void ChromeClassTester::BuildBannedLists() { 222 void ChromeClassTester::BuildBannedLists() {
223 banned_namespaces_.emplace("std"); 223 banned_namespaces_.emplace("std");
224 banned_namespaces_.emplace("__gnu_cxx"); 224 banned_namespaces_.emplace("__gnu_cxx");
225 225
226 if (options_.enforce_in_thirdparty_webkit) { 226 if (options_.enforce_in_thirdparty_webkit) {
227 allowed_directories_.emplace("/third_party/WebKit/"); 227 allowed_directories_.emplace("/third_party/WebKit/");
228 } 228 }
229 229
230 if (!options_.enforce_in_pdf) {
231 banned_directories_.emplace("/pdf/");
232 }
233
230 banned_directories_.emplace("/third_party/"); 234 banned_directories_.emplace("/third_party/");
231 banned_directories_.emplace("/native_client/"); 235 banned_directories_.emplace("/native_client/");
232 banned_directories_.emplace("/breakpad/"); 236 banned_directories_.emplace("/breakpad/");
233 banned_directories_.emplace("/courgette/"); 237 banned_directories_.emplace("/courgette/");
234 banned_directories_.emplace("/pdf/");
235 banned_directories_.emplace("/ppapi/"); 238 banned_directories_.emplace("/ppapi/");
236 banned_directories_.emplace("/usr/include/"); 239 banned_directories_.emplace("/usr/include/");
237 banned_directories_.emplace("/usr/lib/"); 240 banned_directories_.emplace("/usr/lib/");
238 banned_directories_.emplace("/usr/local/include/"); 241 banned_directories_.emplace("/usr/local/include/");
239 banned_directories_.emplace("/usr/local/lib/"); 242 banned_directories_.emplace("/usr/local/lib/");
240 banned_directories_.emplace("/testing/"); 243 banned_directories_.emplace("/testing/");
241 banned_directories_.emplace("/v8/"); 244 banned_directories_.emplace("/v8/");
242 banned_directories_.emplace("/dart/"); 245 banned_directories_.emplace("/dart/");
243 banned_directories_.emplace("/sdch/"); 246 banned_directories_.emplace("/sdch/");
244 banned_directories_.emplace("/icu4c/"); 247 banned_directories_.emplace("/icu4c/");
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
329 } 332 }
330 333
331 *filename = ploc.getFilename(); 334 *filename = ploc.getFilename();
332 return true; 335 return true;
333 } 336 }
334 337
335 DiagnosticsEngine::Level ChromeClassTester::getErrorLevel() { 338 DiagnosticsEngine::Level ChromeClassTester::getErrorLevel() {
336 return diagnostic().getWarningsAsErrors() ? DiagnosticsEngine::Error 339 return diagnostic().getWarningsAsErrors() ? DiagnosticsEngine::Error
337 : DiagnosticsEngine::Warning; 340 : DiagnosticsEngine::Warning;
338 } 341 }
OLDNEW
« no previous file with comments | « pdf/preview_mode_client.h ('k') | tools/clang/plugins/FindBadConstructsAction.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698