Mark methods with override in pdf/

tools/clang/plugins/ChromeClassTester.cpp

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // A general interface for filtering and only acting on classes in Chromium C++
 // code.
 
 #include "ChromeClassTester.h"
 
 #include <algorithm>
@@ skipping 213 matching lines @@
   banned_namespaces_.emplace("__gnu_cxx");
 
   if (options_.enforce_in_thirdparty_webkit) {
     allowed_directories_.emplace("/third_party/WebKit/");
   }
 
   banned_directories_.emplace("/third_party/");
   banned_directories_.emplace("/native_client/");
   banned_directories_.emplace("/breakpad/");
   banned_directories_.emplace("/courgette/");
-  banned_directories_.emplace("/pdf/");

[Nico, 2015/12/29 19:05:40]

In general, we put changes like this behind a flag. The plugin is bundled with
clang, so this will have an effect the next time we roll clang. Rolling clang is
already very hard, so we don't want to be blocked on a certain directory having
to be plugin-clean for the roll. So put this behind a flag, wait for the roll,
then toggle the flag async after the roll. (And then the flag can be removed
again.)

[Lei Zhang, 2015/12/29 19:14:51]

Sure, will do shortly.

   banned_directories_.emplace("/ppapi/");
   banned_directories_.emplace("/usr/include/");
   banned_directories_.emplace("/usr/lib/");
   banned_directories_.emplace("/usr/local/include/");
   banned_directories_.emplace("/usr/local/lib/");
   banned_directories_.emplace("/testing/");
   banned_directories_.emplace("/v8/");
   banned_directories_.emplace("/dart/");
   banned_directories_.emplace("/sdch/");
   banned_directories_.emplace("/icu4c/");
@@ skipping 84 matching lines @@
   }
 
   *filename = ploc.getFilename();
   return true;
 }
 
 DiagnosticsEngine::Level ChromeClassTester::getErrorLevel() {
   return diagnostic().getWarningsAsErrors() ? DiagnosticsEngine::Error
                                             : DiagnosticsEngine::Warning;
 }