Issue 155453002: Update all the client code to use a single WebThemeEngine.h header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155453002: Update all the client code to use a single WebThemeEngine.h header. (Closed)

Created:
6 years, 10 months ago by Dirk Pranke

Modified:
6 years, 10 months ago

Reviewers:
jamesr, piman

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -5 lines)			Patch
M	content/child/webthemeengine_impl_android.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/child/webthemeengine_impl_default.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/child/webthemeengine_impl_mac.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/shell/renderer/test_runner/WebTestThemeEngineMac.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/shell/renderer/test_runner/WebTestThemeEngineMock.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (0 generated)

Dirk Pranke

This patch depends on https://codereview.chromium.org/154733004/ having landed (and rolled into Chromium).

6 years, 10 months ago (2014-02-05 01:19:17 UTC) #1

Dirk Pranke

Looks like jam@ is out, piman@, can you give an OWNERS approval for this?

6 years, 10 months ago (2014-02-06 00:32:14 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/155453002/1

6 years, 10 months ago (2014-02-12 21:06:58 UTC) #6

Message was sent while issue was closed.

Change committed as 250851