Refactoring usage of GetWebSiteSetting() code for SetNarrowestContentSetting().

While calling GetWebSettings() from SetNarrowestContentSetting(), we don't need
to check content setting logic in GetWebsiteSetting(), instead we can call
GetWebsiteSettingInternal() directly.

BUG=572827
Committed: https://crrev.com/a93f6e900c8decc0d7e5fde7c8b868c42e93903c
Cr-Commit-Position: refs/heads/master@{#367805}

[Deepak, 2015-12-29 10:21:57]

Description was changed from

==========
Moving ContentSetting Specific code from GetWebSiteSetting() to
GetContentSetting().

BUG=
==========

to

==========
1.Adding ContentSetting Specific code to GetContentSetting().
2. Introduced GetWebsiteSettingWithoutWhiteList() API to get the website setting
without checking whitelist.

BUG=
==========

[Deepak, 2015-12-29 10:22:33]

Description was changed from

==========
1.Adding ContentSetting Specific code to GetContentSetting().
2. Introduced GetWebsiteSettingWithoutWhiteList() API to get the website setting
without checking whitelist.

BUG=
==========

to

==========
1.Adding ContentSetting Specific code to GetContentSetting().
2.Introduced GetWebsiteSettingWithoutWhiteList() API to get the website setting
without checking whitelist.

BUG=
==========

[Deepak, 2015-12-29 10:52:24]

Description was changed from

==========
1.Adding ContentSetting Specific code to GetContentSetting().
2.Introduced GetWebsiteSettingWithoutWhiteList() API to get the website setting
without checking whitelist.

BUG=
==========

to

==========
1.Adding ContentSetting Specific code to GetContentSetting().
2.Introduced GetWebsiteSettingWithoutWhiteList() API to get the website setting
without checking whitelist.

BUG=572827
==========

[Deepak, 2015-12-29 10:52:24]

deepak.m1@samsung.com changed reviewers:
+ bauerb@chromium.org

[Deepak, 2015-12-29 10:52:45]

PTAL

[raymes, 2016-01-04 00:00:39]

raymes@chromium.org changed reviewers:
+ raymes@chromium.org

[raymes, 2016-01-04 00:00:40]

Hey Deepak! I'm not entirely sure this CL is an improvement over the existing
code.

https://codereview.chromium.org/1554513002/diff/40001/components/content_sett...
File components/content_settings/core/browser/host_content_settings_map.cc
(right):

https://codereview.chromium.org/1554513002/diff/40001/components/content_sett...
components/content_settings/core/browser/host_content_settings_map.cc:221: }
What's the benefit of duplicating this logic instead of just calling
GetWebsiteSetting?

https://codereview.chromium.org/1554513002/diff/40001/components/content_sett...
components/content_settings/core/browser/host_content_settings_map.cc:634: //
check the whitelisted scheme.
That doesn't necessarily mean that we should have the logic here, we may want to
change the call site instead.

https://codereview.chromium.org/1554513002/diff/40001/components/content_sett...
components/content_settings/core/browser/host_content_settings_map.cc:663:
HostContentSettingsMap::GetWebsiteSettingWithoutWhiteList(
I'm not really sure what the use of adding this is? How is it different to
GetWebsiteSettingInternal?

[Deepak, 2016-01-04 05:56:29]

Description was changed from

==========
1.Adding ContentSetting Specific code to GetContentSetting().
2.Introduced GetWebsiteSettingWithoutWhiteList() API to get the website setting
without checking whitelist.

BUG=572827
==========

to

==========
While calling GetWebSettings() from SetNarrowestContentSetting(), we don't need
to check content setting logic in GetWebsiteSetting(), instead we can call
GetWebsiteSettingInternal() directly.

BUG=572827
==========

[Deepak, 2016-01-04 07:06:56]

Description was changed from

==========
While calling GetWebSettings() from SetNarrowestContentSetting(), we don't need
to check content setting logic in GetWebsiteSetting(), instead we can call
GetWebsiteSettingInternal() directly.

BUG=572827
==========

to

==========
While calling GetWebSettings() from SetNarrowestContentSetting(), we don't need
to check content setting logic in GetWebsiteSetting(), instead we can call
GetWebsiteSettingInternal() directly.

BUG=572827
==========

[Deepak, 2016-01-04 07:43:44]

PTAL

https://codereview.chromium.org/1554513002/diff/40001/components/content_sett...
File components/content_settings/core/browser/host_content_settings_map.cc
(right):

https://codereview.chromium.org/1554513002/diff/40001/components/content_sett...
components/content_settings/core/browser/host_content_settings_map.cc:221: }
On 2016/01/04 00:00:40, raymes wrote:
> What's the benefit of duplicating this logic instead of just calling
> GetWebsiteSetting?

Done.

https://codereview.chromium.org/1554513002/diff/40001/components/content_sett...
components/content_settings/core/browser/host_content_settings_map.cc:634: //
check the whitelisted scheme.
On 2016/01/04 00:00:40, raymes wrote:
> That doesn't necessarily mean that we should have the logic here, we may want
to
> change the call site instead.

Acknowledged.

https://codereview.chromium.org/1554513002/diff/40001/components/content_sett...
components/content_settings/core/browser/host_content_settings_map.cc:663:
HostContentSettingsMap::GetWebsiteSettingWithoutWhiteList(
On 2016/01/04 00:00:40, raymes wrote:
> I'm not really sure what the use of adding this is? How is it different to
> GetWebsiteSettingInternal?

I just wanted to segregate the usage of GetWebsiteSetting() and
GetWebsiteSettingInternal() call.
I agree with you that we just need to call GetWebsiteSettingInternal() from
SetNarrowestContentSetting() instead of calling GetWebsiteSetting(), as We don't
require content_settings to set to whitelisted at that place, so checking
content setting is not required at SetNarrowestContentSetting().

[raymes, 2016-01-06 08:14:15]

lgtm

[Deepak, 2016-01-06 08:21:58]

The CQ bit was checked by deepak.m1@samsung.com

[commit-bot: I haz the power, 2016-01-06 08:22:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1554513002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1554513002/60001

[commit-bot: I haz the power, 2016-01-06 10:00:42]

Description was changed from

==========
While calling GetWebSettings() from SetNarrowestContentSetting(), we don't need
to check content setting logic in GetWebsiteSetting(), instead we can call
GetWebsiteSettingInternal() directly.

BUG=572827
==========

to

==========
While calling GetWebSettings() from SetNarrowestContentSetting(), we don't need
to check content setting logic in GetWebsiteSetting(), instead we can call
GetWebsiteSettingInternal() directly.

BUG=572827
==========

[commit-bot: I haz the power, 2016-01-06 10:00:42]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-06 10:01:32]

Description was changed from

==========
While calling GetWebSettings() from SetNarrowestContentSetting(), we don't need
to check content setting logic in GetWebsiteSetting(), instead we can call
GetWebsiteSettingInternal() directly.

BUG=572827
==========

to

==========
While calling GetWebSettings() from SetNarrowestContentSetting(), we don't need
to check content setting logic in GetWebsiteSetting(), instead we can call
GetWebsiteSettingInternal() directly.

BUG=572827

Committed: https://crrev.com/a93f6e900c8decc0d7e5fde7c8b868c42e93903c
Cr-Commit-Position: refs/heads/master@{#367805}
==========

[commit-bot: I haz the power, 2016-01-06 10:01:33]

Patchset 4 (id:??) landed as
https://crrev.com/a93f6e900c8decc0d7e5fde7c8b868c42e93903c
Cr-Commit-Position: refs/heads/master@{#367805}