Issue 155451: Support individual Keychain item deletion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155451: Support individual Keychain item deletion (Closed)

Created:
11 years, 5 months ago by stuartmorgan

Modified:
9 years, 7 months ago

Reviewers:
TVL

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Support individual Keychain item deletion in PasswordStoreMac. Rename AddLogin to AddPassword for consistency with other method names. Remove a confusing out param from the form merge check function. BUG=16486 TEST=Once the UI exists, deleting individual passwords should work on the Mac. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20573

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+180 lines, -58 lines)			Patch
M	chrome/browser/keychain_mac.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/keychain_mac.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/keychain_mock_mac.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/keychain_mock_mac.cc	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	chrome/browser/password_manager/password_store_mac.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/password_manager/password_store_mac.cc	View	13 chunks	+77 lines, -24 lines	0 comments	Download
M	chrome/browser/password_manager/password_store_mac_internal.h	View	4 chunks	+15 lines, -7 lines	0 comments	Download
M	chrome/browser/password_manager/password_store_mac_unittest.cc	View	10 chunks	+66 lines, -27 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

TVL

11 years, 5 months ago (2009-07-13 22:11:37 UTC) #2

lgtm

 might want to beef up the cl comment since it also adds a method, renames one,
etc.

Expand Messages | Collapse Messages