Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1554443002: [Sync] ModelTypeCount UMA doesn't include server-side only unapplied entries (Closed)

Created:
4 years, 12 months ago by Gang Wu
Modified:
4 years, 12 months ago
Reviewers:
stanisc
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use server-side ModelTypeCount when it did not apply yet. BUG=571488 Committed: https://crrev.com/aca8ba5b170cf01bbbc3d43d1b2ac87062af6d64 Cr-Commit-Position: refs/heads/master@{#367023}

Patch Set 1 #

Patch Set 2 : start from 0 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M sync/syncable/directory_backing_store.cc View 1 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Gang Wu
Please take a look.
4 years, 12 months ago (2015-12-28 21:58:54 UTC) #3
stanisc
lgtm
4 years, 12 months ago (2015-12-28 22:18:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1554443002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1554443002/20001
4 years, 12 months ago (2015-12-28 23:08:58 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 12 months ago (2015-12-28 23:47:09 UTC) #9
commit-bot: I haz the power
4 years, 12 months ago (2015-12-28 23:48:09 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aca8ba5b170cf01bbbc3d43d1b2ac87062af6d64
Cr-Commit-Position: refs/heads/master@{#367023}

Powered by Google App Engine
This is Rietveld 408576698