Mac pop-up window happier-ness....

Mac pop-up window happier-ness.

BUG=http://crbug.com/15727, http://crbug.com/16063, http://crbug.com/16329

TEST=A few things.
Bookmark bar test (16063):
- open bookmark bar, then open popup.  Popup should not have bmb.
- close bookmark bar, then open popup.  Popup should not have bmb.
- In main window, toggle bmb a few times.  Popup should not change.
Tab at bottom bug (16329):
- Open 'details' popup in gmail (next to 'last acct activity')
- make sure no tab strip at the bottom of the window
General (15727):
- Open a popup.  Make sure no toolbar (back/fwd buttons et al)


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20773

[pink (ping after 24hrs), 2009-07-14 14:22:09]

LGTM

http://codereview.chromium.org/155444/diff/22/1015
File chrome/browser/cocoa/bookmark_bar_controller_unittest.mm (right):

http://codereview.chromium.org/155444/diff/22/1015#newcode64
Line 64: // Awkwardness to look like we've been installed
period at end of sentence.

http://codereview.chromium.org/155444/diff/22/1012
File chrome/browser/cocoa/tab_window_controller.mm (right):

http://codereview.chromium.org/155444/diff/22/1012#newcode32
Line 32: // No tabstrip so remove the tabContentArea offset
period at end of sentence

http://codereview.chromium.org/155444/diff/22/1014
File chrome/browser/cocoa/toolbar_controller.h (right):

http://codereview.chromium.org/155444/diff/22/1014#newcode113
Line 113: // around).  This This changes the behavior of other methods, like
s/This This/This. What does it mean to turn off the toolbar but have a location
bar?

[John Grabowski, 2009-07-14 18:39:49]

All comment feedback applied.

http://codereview.chromium.org/155444/diff/22/1014
File chrome/browser/cocoa/toolbar_controller.h (right):

http://codereview.chromium.org/155444/diff/22/1014#newcode113
Line 113: // around).  This This changes the behavior of other methods, like
On 2009/07/14 14:22:09, pink wrote:
> s/This This/This. What does it mean to turn off the toolbar but have a
location
> bar?

It means "yes URL bar, no buttons (stop/referesh/back/fwd), no bookmark bar,
etc".... like windows.