Issue 155443002: Do not build the Mock WebThemeEngine implementation on the Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155443002: Do not build the Mock WebThemeEngine implementation on the Mac. (Closed)

Created:
6 years, 10 months ago by Dirk Pranke

Modified:
6 years, 10 months ago

Reviewers:
jamesr, piman

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Do not build the Mock WebThemeEngine implementation on the Mac. Since it doesn't actually work. R=jamesr@chromium.org, piman@chromium.org BUG=327471 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249319

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	content/content_shell.gypi	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 8 (0 generated)

Dirk Pranke

On 2014/02/05 01:18:53, jamesr wrote: > lgtm John, can I get an OWNERS approval?

6 years, 10 months ago (2014-02-05 19:41:52 UTC) #3

Dirk Pranke

Looks like jam@ is out, piman@, can you give an OWNERS approval for this?

6 years, 10 months ago (2014-02-06 00:32:51 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/155443002/1

6 years, 10 months ago (2014-02-06 00:48:50 UTC) #7

Message was sent while issue was closed.

Change committed as 249319