scripts/slave/recipes/findit/chromium/compile.py - Issue 1554383003: Add support for "additional_mirrors" property in trybot configs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/findit/chromium/compile.py

Issue 1554383003: Add support for "additional_mirrors" property in trybot configs. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/recipes/chromium_trybot.py ('K') | « scripts/slave/recipes/chromium_trybot.expected/telemetry_gpu_harness_failure.json ('k') | scripts/slave/recipes/findit/chromium/test.py » ('j') | tests/masters_recipes_test.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/findit/chromium/compile.py

diff --git a/scripts/slave/recipes/findit/chromium/compile.py b/scripts/slave/recipes/findit/chromium/compile.py

index 67f1d4c32f226e869ad0b16485cfc30ccc6f1115..384e882a3df4bf2f3ae908113d7febe504a68327 100644

--- a/scripts/slave/recipes/findit/chromium/compile.py

+++ b/scripts/slave/recipes/findit/chromium/compile.py

@@ -50,7 +50,7 @@ def _run_compile_at_revision(api, target_mastername, target_buildername,

revision, compile_targets, use_analyze):

with api.step.nest('test %s' % str(revision)):

# Checkout code at the given revision to recompile.

- bot_update_step, master_dict, test_spec = \

+ bot_update_step, master_dicts, test_specs = \

api.chromium_tests.prepare_checkout(

target_mastername,

target_buildername,

@@ -64,8 +64,9 @@ def _run_compile_at_revision(api, target_mastername, target_buildername,

compile_targets, _ = api.chromium_tests.get_compile_targets_and_tests(

target_mastername,

target_buildername,

- master_dict,

- test_spec,

+ master_dicts,

+ None,

+ test_specs,

override_bot_type='builder_tester')

if use_analyze:

@@ -89,7 +90,7 @@ def _run_compile_at_revision(api, target_mastername, target_buildername,

target_mastername,

target_buildername,

bot_update_step,

- master_dict,

+ master_dicts,

compile_targets,

tests_including_triggered=[],

mb_mastername=target_mastername,