scripts/slave/recipes/chromium.py - Issue 1554383003: Add support for "additional_mirrors" property in trybot configs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium.py

Issue 1554383003: Add support for "additional_mirrors" property in trybot configs. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/recipe_modules/chromium_tests/trybots.py ('K') | « scripts/slave/recipes/bisection/desktop_bisect.py ('k') | scripts/slave/recipes/chromium.expected/full_chromium_gpu_GPU_Linux_Builder.json » ('j') | scripts/slave/recipes/chromium_trybot.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium.py

diff --git a/scripts/slave/recipes/chromium.py b/scripts/slave/recipes/chromium.py

index 0b14c138fef5c7f28e41f50580aff27b42dd62f1..d68f48c57e7b476ffc0e43ecfc0008d9d996f54c 100644

--- a/scripts/slave/recipes/chromium.py

+++ b/scripts/slave/recipes/chromium.py

@@ -51,14 +51,14 @@ def RunSteps(api):

api.bisect_tester.upload_job_url()

api.chromium_tests.configure_build(mastername, buildername)

- update_step, master_dict, test_spec = \

+ update_step, master_dicts, test_specs = \

api.chromium_tests.prepare_checkout(mastername, buildername)

- api.chromium_tests.compile(mastername, buildername, update_step, master_dict,

- test_spec)

+ api.chromium_tests.compile(mastername, buildername, update_step, master_dicts,

+ None, test_specs)

api.chromium_tests.download_and_unzip_build(mastername, buildername,

- update_step, master_dict)

+ update_step, master_dicts)

tests = api.chromium_tests.tests_for_builder(

- mastername, buildername, update_step, master_dict)

+ mastername, buildername, update_step, master_dicts[0])

Sergey Berezin 2016/01/06 01:50:56 Is it guaranteed that master_dicts is always of si

if not tests:

return