Add support for "additional_mirrors" property in trybot configs.

scripts/slave/recipe_modules/chromium_tests/trybots.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from recipe_engine.types import freeze
 
 
 TRYBOTS = freeze({
   'tryserver.blink': {
     'builders': {
@@ skipping 249 matching lines @@
         'buildername': 'Linux ChromiumOS GN (dbg)',
       },
       'linux_chromium_gn_chromeos_rel': {
         'mastername': 'chromium.chromiumos',
         'buildername': 'Linux ChromiumOS GN',
       },
       'linux_chromium_rel_ng': {
         'mastername': 'chromium.linux',
         'buildername': 'Linux Builder',
         'tester': 'Linux Tests',
+        # TODO(kbr): add this to the other trybots that run GPU tests.
+        # This is only being added now in order to achieve full code
+        # coverage in the recipes.
+        'additional_mirrors': [

[Sergey Berezin, 2016/01/06 01:50:56]

nit on the design: it might make sense to generalize the config, e.g. to:

  linux_chromium_rel_ng: [
   {
     'mastername': 'chromium.linux',
     'buildername': 'Linux Builder',
     'tester': 'Linux Tests',
   },
   {
      'mastername': 'chromium.gpu',
      'buildername': 'GPU Linux Builder',
      'tester': 'Linux Release (NVIDIA)',
    },
   ]

and allow a single dict as an option for backward compatibility, but interpreted
as a single element list. WDYT?

[Ken Russell (switch to Gerrit), 2016/01/06 03:30:07]

That's certainly feasible. I don't know whether it'd be preferable. Currently in
this CL I tried to minimize the potential impact to the existing trybot
configurations, code, etc. by making the additional_mirrors "mixin" optional.
Happy to change it (or even change all of these trybots' configurations into
lists of dictionaries, and change the required format).

[Sergey Berezin, 2016/01/06 19:12:35]

To be clear, what I'm proposing is backward-compatible to other configs (no
changes necessary), and it'll likely simplify your code.

Specifically, if you add logic to interpret 'builder': { ... } as 'builder': [{
... }] early on, you only need the code you already have for
'additional_mirrors', and can kill the special handling of the original fields.

But I'll leave it up to you and Pawel for a final form. My only concern is the
already non-trivial configuration grows yet another special flag, and it doesn't
really have to.

+          {
+            'mastername': 'chromium.gpu',
+            'buildername': 'GPU Linux Builder',
+            'tester': 'Linux Release (NVIDIA)',
+          },
+        ],
       },
       'linux_chromium_asan_rel_ng': {
         'mastername': 'chromium.memory',
         'buildername': 'Linux ASan LSan Builder',
         'tester': 'Linux ASan LSan Tests (1)',
       },
       'linux_chromium_compile_dbg_ng': {
         'mastername': 'chromium.linux',
         'buildername': 'Linux Builder (dbg)',
         'analyze_mode': 'compile',
@@ skipping 245 matching lines @@
         'buildername': 'CrWinClang64',
       },
       # Optional GPU bots.
       'win_optional_gpu_tests_rel': {
         'mastername': 'chromium.win',
         'buildername': 'Win Builder',
       },
     },
   },
 })