Fix failure in printing/BUILD.gn when not using a sysroot. Without this change, gn gen fails with "…

Fix failure in printing/BUILD.gn when not using a sysroot. Without this change, gn gen fails with "cups-config not found: usr/bin/cups-config".

BUG=504446
Committed: https://crrev.com/b4d790c920ac0b128fc655a300b2bb09746fd2c8
Cr-Commit-Position: refs/heads/master@{#367558}

[Adam Goode, 2016-01-05 03:08:31]

agoode@chromium.org changed reviewers:
+ phajdan.jr@chromium.org, sbc@chromium.org, thestig@chromium.org

[Lei Zhang, 2016-01-05 03:14:08]

Oh, is gn running:

printing/cups_config_helper.py --some_switch ''

?

https://codereview.chromium.org/1554383002/diff/1/printing/cups_config_helper.py
File printing/cups_config_helper.py (right):

https://codereview.chromium.org/1554383002/diff/1/printing/cups_config_helper...
printing/cups_config_helper.py:25: print 'usage: %s
{--api-version|--cflags|--ldflags|--libs|--libs-for-gn}' % \
BTW, do you mind updating this to mention the sysroot while you are here?

[Adam Goode, 2016-01-05 13:54:07]

On 2016/01/05 03:14:08, Lei Zhang wrote:
> Oh, is gn running:
> 
> printing/cups_config_helper.py --some_switch ''
> 
> ?

Yes, that's what's happening now. I could have changed BUILD.gn but that was
more messy.

> 
>
https://codereview.chromium.org/1554383002/diff/1/printing/cups_config_helper.py
> File printing/cups_config_helper.py (right):
> 
>
https://codereview.chromium.org/1554383002/diff/1/printing/cups_config_helper...
> printing/cups_config_helper.py:25: print 'usage: %s
> {--api-version|--cflags|--ldflags|--libs|--libs-for-gn}' % \
> BTW, do you mind updating this to mention the sysroot while you are here?

[Adam Goode, 2016-01-05 13:54:09]

On 2016/01/05 03:14:08, Lei Zhang wrote:
> Oh, is gn running:
> 
> printing/cups_config_helper.py --some_switch ''
> 
> ?

Yes, that's what's happening now. I could have changed BUILD.gn but that was
more messy.

> 
>
https://codereview.chromium.org/1554383002/diff/1/printing/cups_config_helper.py
> File printing/cups_config_helper.py (right):
> 
>
https://codereview.chromium.org/1554383002/diff/1/printing/cups_config_helper...
> printing/cups_config_helper.py:25: print 'usage: %s
> {--api-version|--cflags|--ldflags|--libs|--libs-for-gn}' % \
> BTW, do you mind updating this to mention the sysroot while you are here?

[Adam Goode, 2016-01-05 13:54:22]

https://codereview.chromium.org/1554383002/diff/1/printing/cups_config_helper.py
File printing/cups_config_helper.py (right):

https://codereview.chromium.org/1554383002/diff/1/printing/cups_config_helper...
printing/cups_config_helper.py:25: print 'usage: %s
{--api-version|--cflags|--ldflags|--libs|--libs-for-gn}' % \
On 2016/01/05 03:14:08, Lei Zhang wrote:
> BTW, do you mind updating this to mention the sysroot while you are here?

Done.

[Lei Zhang, 2016-01-05 17:13:04]

Thanks, lgtm.

[Lei Zhang, 2016-01-05 17:15:06]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-01-05 17:15:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1554383002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1554383002/20001

[commit-bot: I haz the power, 2016-01-05 17:20:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-05 17:21:43]

Description was changed from

==========
Fix failure in printing/BUILD.gn when not using a sysroot. Without this change,
gn gen fails with "cups-config not found: usr/bin/cups-config".

BUG=504446
==========

to

==========
Fix failure in printing/BUILD.gn when not using a sysroot. Without this change,
gn gen fails with "cups-config not found: usr/bin/cups-config".

BUG=504446

Committed: https://crrev.com/b4d790c920ac0b128fc655a300b2bb09746fd2c8
Cr-Commit-Position: refs/heads/master@{#367558}
==========

[commit-bot: I haz the power, 2016-01-05 17:21:44]

Patchset 2 (id:??) landed as
https://crrev.com/b4d790c920ac0b128fc655a300b2bb09746fd2c8
Cr-Commit-Position: refs/heads/master@{#367558}