Make FPDF_WIDESTRING work regardless of endianness.

fpdfsdk/src/fpdfdoc_embeddertest.cpp

 // Copyright 2015 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/include/fxcrt/fx_string.h"
 #include "public/fpdf_doc.h"
 #include "public/fpdfview.h"
 #include "testing/embedder_test.h"
 #include "testing/fx_string_testhelpers.h"
+#include "testing/test_support.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 class FPDFDocEmbeddertest : public EmbedderTest {};
 
 TEST_F(FPDFDocEmbeddertest, DestGetPageIndex) {
   EXPECT_TRUE(OpenDocument("named_dests.pdf"));
 
   // NULL FPDF_DEST case.
   EXPECT_EQ(0U, FPDFDest_GetPageIndex(document(), nullptr));
 
@@ skipping 74 matching lines @@
   FPDF_BOOKMARK sibling = FPDFBookmark_GetNextSibling(document(), child);
   EXPECT_NE(nullptr, sibling);
   EXPECT_EQ(28, FPDFBookmark_GetTitle(sibling, buf, sizeof(buf)));
   EXPECT_EQ(CFX_WideString(L"A Good Ending"),
             CFX_WideString::FromUTF16LE(buf, 13));
 
   EXPECT_EQ(nullptr, FPDFBookmark_GetNextSibling(document(), sibling));
 }
 
 TEST_F(FPDFDocEmbeddertest, FindBookmarks) {
-  // Open a file with two bookmarks, and extract the first.
+  // Open a file with two bookmarks.
   EXPECT_TRUE(OpenDocument("bookmarks.pdf"));
 
+  // Find the first one, based on its known title.
+  FPDF_WIDESTRING title = GetFPDFWideString(L"A Good Beginning");
+  FPDF_BOOKMARK child = FPDFBookmark_Find(document(), title);
+  EXPECT_NE(nullptr, child);
+
+  // Check that the string matches.
   unsigned short buf[128];
-  FPDF_BOOKMARK child = FPDFBookmark_GetFirstChild(document(), nullptr);
-  EXPECT_NE(nullptr, child);
   EXPECT_EQ(34, FPDFBookmark_GetTitle(child, buf, sizeof(buf)));
   EXPECT_EQ(CFX_WideString(L"A Good Beginning"),
             CFX_WideString::FromUTF16LE(buf, 16));
 
-  // Find the same one again using the title.
-  EXPECT_EQ(child, FPDFBookmark_Find(document(), buf));
+  // Check that it is them same as the one returned by GetFirstChild.
+  EXPECT_EQ(child, FPDFBookmark_GetFirstChild(document(), nullptr));
 
   // Try to find one using a non-existent title.
-  buf[0] = 'X';
-  EXPECT_EQ(nullptr, FPDFBookmark_Find(document(), buf));
+  FPDF_WIDESTRING bad_title = GetFPDFWideString(L"A BAD Beginning");
+  EXPECT_EQ(nullptr, FPDFBookmark_Find(document(), bad_title));
+
+  // Alas, the typedef includes the "const".

[Lei Zhang, 2016/01/05 02:34:09]

Do you want to make a custom unique_ptr deleter for FPDF_WIDESTRING and use it
in the tests? Make GetFPDFWideString() return a unique_ptr of that type.

[Tom Sepez, 2016/01/05 18:06:23]

I'll do that in a follow-up.  The GetFileContents() helper should do the same
thing.

+  free(const_cast<unsigned short*>(title));
+  free(const_cast<unsigned short*>(bad_title));
 }