Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Issue 1554363002: Make FPDF_WIDESTRING work regardless of endianness. (Closed)

Created:
4 years, 11 months ago by Tom Sepez
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make FPDF_WIDESTRING work regardless of endianness. Given the helper routines, use it in the find bookmark test instead of just trusting another bookmarks title. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/ed34cdf99d5a4b33e57f81f9244a311f6fb86db3

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -17 lines) Patch
M fpdfsdk/src/fpdfdoc_embeddertest.cpp View 2 chunks +16 lines, -7 lines 2 comments Download
M fpdfsdk/src/fpdftext_embeddertest.cpp View 3 chunks +11 lines, -5 lines 0 comments Download
M samples/pdfium_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M testing/embedder_test_timer_handling_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M testing/test_support.h View 1 chunk +5 lines, -1 line 0 comments Download
M testing/test_support.cpp View 2 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Tom Sepez
Lei, for review. Nothing like having an abstraction with no way to operate on it, ...
4 years, 11 months ago (2016-01-05 00:50:38 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1554363002/diff/1/fpdfsdk/src/fpdfdoc_embeddertest.cpp File fpdfsdk/src/fpdfdoc_embeddertest.cpp (right): https://codereview.chromium.org/1554363002/diff/1/fpdfsdk/src/fpdfdoc_embeddertest.cpp#newcode126 fpdfsdk/src/fpdfdoc_embeddertest.cpp:126: // Alas, the typedef includes the "const". Do ...
4 years, 11 months ago (2016-01-05 02:34:09 UTC) #3
Tom Sepez
Committed patchset #1 (id:1) manually as ed34cdf99d5a4b33e57f81f9244a311f6fb86db3 (presubmit successful).
4 years, 11 months ago (2016-01-05 18:06:16 UTC) #5
Tom Sepez
4 years, 11 months ago (2016-01-05 18:06:23 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/1554363002/diff/1/fpdfsdk/src/fpdfdoc_embedde...
File fpdfsdk/src/fpdfdoc_embeddertest.cpp (right):

https://codereview.chromium.org/1554363002/diff/1/fpdfsdk/src/fpdfdoc_embedde...
fpdfsdk/src/fpdfdoc_embeddertest.cpp:126: // Alas, the typedef includes the
"const".
On 2016/01/05 02:34:09, Lei Zhang wrote:
> Do you want to make a custom unique_ptr deleter for FPDF_WIDESTRING and use it
> in the tests? Make GetFPDFWideString() return a unique_ptr of that type.

I'll do that in a follow-up.  The GetFileContents() helper should do the same
thing.

Powered by Google App Engine
This is Rietveld 408576698