Make FPDF_WIDESTRING work regardless of endianness.

Make FPDF_WIDESTRING work regardless of endianness.

Given the helper routines, use it in the find bookmark test
instead of just trusting another bookmarks title.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/ed34cdf99d5a4b33e57f81f9244a311f6fb86db3

[Tom Sepez, 2016-01-05 00:50:38]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-01-05 00:50:38]

Lei, for review.  Nothing like having an abstraction with no way to operate on
it, eh?

[Lei Zhang, 2016-01-05 02:34:09]

lgtm

https://codereview.chromium.org/1554363002/diff/1/fpdfsdk/src/fpdfdoc_embedde...
File fpdfsdk/src/fpdfdoc_embeddertest.cpp (right):

https://codereview.chromium.org/1554363002/diff/1/fpdfsdk/src/fpdfdoc_embedde...
fpdfsdk/src/fpdfdoc_embeddertest.cpp:126: // Alas, the typedef includes the
"const".
Do you want to make a custom unique_ptr deleter for FPDF_WIDESTRING and use it
in the tests? Make GetFPDFWideString() return a unique_ptr of that type.

[Tom Sepez, 2016-01-05 18:06:14]

Description was changed from

==========
Make FPDF_WIDESTRING work regardless of endianness.

Given the helper routines, use it in the find bookmark test
instead of just trusting another bookmarks title.
==========

to

==========
Make FPDF_WIDESTRING work regardless of endianness.

Given the helper routines, use it in the find bookmark test
instead of just trusting another bookmarks title.

R=thestig@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/ed34cdf99d5a4b33e57f81f9244a311f6fb8...
==========

[Tom Sepez, 2016-01-05 18:06:16]

Committed patchset #1 (id:1) manually as
ed34cdf99d5a4b33e57f81f9244a311f6fb86db3 (presubmit successful).

[Tom Sepez, 2016-01-05 18:06:23]

https://codereview.chromium.org/1554363002/diff/1/fpdfsdk/src/fpdfdoc_embedde...
File fpdfsdk/src/fpdfdoc_embeddertest.cpp (right):

https://codereview.chromium.org/1554363002/diff/1/fpdfsdk/src/fpdfdoc_embedde...
fpdfsdk/src/fpdfdoc_embeddertest.cpp:126: // Alas, the typedef includes the
"const".
On 2016/01/05 02:34:09, Lei Zhang wrote:
> Do you want to make a custom unique_ptr deleter for FPDF_WIDESTRING and use it
> in the tests? Make GetFPDFWideString() return a unique_ptr of that type.

I'll do that in a follow-up.  The GetFileContents() helper should do the same
thing.