Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1554273002: PPC: [Interpreter] Fix some issues in the non-x64 InterpreterNotifyDeoptimized builtins. (Closed)

Created:
4 years, 11 months ago by MTBrandyberry
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [Interpreter] Fix some issues in the non-x64 InterpreterNotifyDeoptimized builtins. Port 02072112d14d2960fc730fa5cde6b759c47b61a0 Original commit message: Fix stack push issues on non-x64 platforms for InterpreterNotifyDeoptimized builtins. R=rmcilroy@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:4280 LOG=N Committed: https://crrev.com/90b64b3cb4ebe36c233abcb8f934253110034b99 Cr-Commit-Position: refs/heads/master@{#33098}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M src/ppc/builtins-ppc.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1554273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1554273002/1
4 years, 11 months ago (2016-01-04 21:22:11 UTC) #2
MTBrandyberry
4 years, 11 months ago (2016-01-04 21:22:27 UTC) #3
michael_dawson
On 2016/01/04 21:22:27, mtbrandyberry wrote: lgtm.
4 years, 11 months ago (2016-01-04 21:42:31 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-04 21:47:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1554273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1554273002/1
4 years, 11 months ago (2016-01-04 21:50:55 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-04 21:52:34 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-04 21:52:52 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/90b64b3cb4ebe36c233abcb8f934253110034b99
Cr-Commit-Position: refs/heads/master@{#33098}

Powered by Google App Engine
This is Rietveld 408576698