Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1554133003: Add fpdf_edit basic creation embedder test. (Closed)

Created:
4 years, 11 months ago by Tom Sepez
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -2 lines) Patch
M BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
A fpdfsdk/src/fpdfedit_embeddertest.cpp View 1 1 chunk +18 lines, -0 lines 0 comments Download
M pdfium.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M testing/embedder_test.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M testing/embedder_test.cpp View 1 3 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Tom Sepez
Lei, for review. Would like to get to a point where each of the public ...
4 years, 11 months ago (2016-01-04 20:05:28 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1554133003/diff/1/fpdfsdk/src/fpdfedit_embeddertest.cpp File fpdfsdk/src/fpdfedit_embeddertest.cpp (right): https://codereview.chromium.org/1554133003/diff/1/fpdfsdk/src/fpdfedit_embeddertest.cpp#newcode5 fpdfsdk/src/fpdfedit_embeddertest.cpp:5: #include "core/include/fxcrt/fx_string.h" Again, not needed. Also fx_string_testhelpers.h. https://codereview.chromium.org/1554133003/diff/1/testing/embedder_test.h ...
4 years, 11 months ago (2016-01-06 02:05:06 UTC) #3
Tom Sepez
Committed patchset #2 (id:20001) manually as d368261cc8d604286e29ca6358700e6bb051dcaa (presubmit successful).
4 years, 11 months ago (2016-01-06 17:55:49 UTC) #5
Tom Sepez
4 years, 11 months ago (2016-01-06 17:57:10 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1554133003/diff/1/fpdfsdk/src/fpdfedit_embedd...
File fpdfsdk/src/fpdfedit_embeddertest.cpp (right):

https://codereview.chromium.org/1554133003/diff/1/fpdfsdk/src/fpdfedit_embedd...
fpdfsdk/src/fpdfedit_embeddertest.cpp:5: #include
"core/include/fxcrt/fx_string.h"
On 2016/01/06 02:05:06, Lei Zhang wrote:
> Again, not needed. Also fx_string_testhelpers.h.

Done.

https://codereview.chromium.org/1554133003/diff/1/testing/embedder_test.h
File testing/embedder_test.h (right):

https://codereview.chromium.org/1554133003/diff/1/testing/embedder_test.h#new...
testing/embedder_test.h:83: virtual bool CreateDocument();
On 2016/01/06 02:05:06, Lei Zhang wrote:
> CreateEmptyDocument() ?

Sure. Done.

Powered by Google App Engine
This is Rietveld 408576698