dart2js: Do not inline when try is seen.

dart2js: Do not inline when try is seen.

Do not inline in functions containing try, do not inline functions
containing try.  V8 does not optimize functions containing try, so
inlining in such functions or inlining such functions will make
potentially optimizable code become unoptimizable.

This repairs a large performance regression on the Angular 2 change
detection benchmarks.

R=sra@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/97b88e4ee76b50aeb27de1e4085316a704eca5d4

[sra1, 2016-01-04 15:43:17]

LGTM

Longer term we should still do inlining of very simple methods in these
contexts.

[Kevin Millikin (Google), 2016-01-04 18:42:45]

On 2016/01/04 15:43:17, sra1 wrote:
> LGTM
> 
> Longer term we should still do inlining of very simple methods in these
> contexts.

Yeah.  That goes nicely with the idea of having different thresholds for
different contexts (e.g., based on loop nesting depth).

[Kevin Millikin (Google), 2016-01-06 22:24:30]

Description was changed from

==========
dart2js: Do not inline when try is seen.

Do not inline in functions containing try, do not inline functions
containing try.  V8 does not optimize functions containing try, so
inlining in such functions or inlining such functions will make
potentially optimizable code become unoptimizable.

This repairs a large performance regression on the Angular 2 change
detection benchmarks.

R=sra@google.com
BUG=
==========

to

==========
dart2js: Do not inline when try is seen.

Do not inline in functions containing try, do not inline functions
containing try.  V8 does not optimize functions containing try, so
inlining in such functions or inlining such functions will make
potentially optimizable code become unoptimizable.

This repairs a large performance regression on the Angular 2 change
detection benchmarks.

R=sra@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/97b88e4ee76b50aeb27de1e4085316a704eca5d4
==========

[Kevin Millikin (Google), 2016-01-06 22:24:32]

Committed patchset #1 (id:1) manually as
97b88e4ee76b50aeb27de1e4085316a704eca5d4 (presubmit successful).