Add autofill dropdown support for password forms.

webkit/glue/editor_client_impl.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // The Mac interface forwards most of these commands to the application layer,
 // and I'm not really sure what to do about most of them.
 
 #include "config.h"
 #include "webkit/glue/editor_client_impl.h"
 
@@ skipping 55 matching lines @@
   }
   d->UserMetricsRecordComputedAction(UTF8ToWide(command_name));
 }
 
 }
 
 EditorClientImpl::EditorClientImpl(WebView* web_view)
     : web_view_(static_cast<WebViewImpl*>(web_view)),
       use_editor_delegate_(false),
       in_redo_(false),
-      backspace_pressed_(false),
+      backspace_or_delete_pressed_(false),
       spell_check_this_field_status_(SPELLCHECK_AUTOMATIC),
 // Don't complain about using "this" in initializer list.
 MSVC_PUSH_DISABLE_WARNING(4355)
       autofill_factory_(this) {
 MSVC_POP_WARNING()
 }
 
 EditorClientImpl::~EditorClientImpl() {
 }
 
@@ skipping 655 matching lines @@
   std::wstring name = AutofillForm::GetNameForInputElement(input_element);
   if (name.empty())  // If the field has no name, then we won't have values.
     return false;
 
   // Don't attempt to autofill with values that are too large.
   if (input_element->value().length() > kMaximumTextSizeForAutofill)
     return false;
 
   if (!requires_caret_at_end) {
     DoAutofill(input_element, form_autofill_only, autofill_on_empty_value,
-               false, backspace_pressed_);
+               false, backspace_or_delete_pressed_);
   } else {
     // We post a task for doing the autofill as the caret position is not set
     // properly at this point (http://bugs.webkit.org/show_bug.cgi?id=16976) and
     // we need it to determine whether or not to trigger autofill.
     std::wstring value =
         webkit_glue::StringToStdWString(input_element->value());
     MessageLoop::current()->PostTask(
         FROM_HERE,
         autofill_factory_.NewRunnableMethod(&EditorClientImpl::DoAutofill,
                                             input_element,
                                             form_autofill_only,
                                             autofill_on_empty_value,
                                             true,
-                                            backspace_pressed_));
+                                            backspace_or_delete_pressed_));
   }
   return true;
 }
 
 void EditorClientImpl::DoAutofill(WebCore::HTMLInputElement* input_element,
                                   bool form_autofill_only,
                                   bool autofill_on_empty_value,
                                   bool requires_caret_at_end,
                                   bool backspace) {
   std::wstring value = webkit_glue::StringToStdWString(input_element->value());
@@ skipping 13 matching lines @@
   // We won't trigger form autofill in that case, as having both behavior on
   // a node would be confusing.
   WebFrameImpl* webframe =
       WebFrameImpl::FromFrame(input_element->document()->frame());
   webkit_glue::PasswordAutocompleteListener* listener =
       webframe->GetPasswordListener(input_element);
   if (listener) {
     if (form_autofill_only)
       return;
 
-    if (backspace)  // No autocomplete for password on backspace.
-      return;
-
-    listener->OnInlineAutocompleteNeeded(input_element, value);
+    listener->OnInlineAutocompleteNeeded(input_element, value, backspace, true);
     return;
   }
 
   // Then trigger form autofill.
   std::wstring name = AutofillForm::GetNameForInputElement(input_element);
   DCHECK_GT(static_cast<int>(name.length()), 0);
   web_view_->delegate()->QueryFormFieldAutofill(name, value,
       reinterpret_cast<int64>(input_element));
 }
 
+void EditorClientImpl::OnAutofillSuggestionAccepted(
+    WebCore::HTMLInputElement* text_field) {
+  WebFrameImpl* webframe =
+      WebFrameImpl::FromFrame(text_field->document()->frame());
+  webkit_glue::PasswordAutocompleteListener* listener =
+      webframe->GetPasswordListener(text_field);
+  std::wstring value = webkit_glue::StringToStdWString(text_field->value());
+  // Password listeners need to autocomplete other fields that depend on the
+  // input element with autofill suggestions.
+  if (listener)
+    listener->OnInlineAutocompleteNeeded(text_field, value, false, false);
+}
+
 bool EditorClientImpl::doTextFieldCommandFromEvent(
     WebCore::Element* element,
     WebCore::KeyboardEvent* event) {
   // Remember if backspace was pressed for the autofill.  It is not clear how to
   // find if backspace was pressed from textFieldDidBeginEditing and
   // textDidChangeInTextField as when these methods are called the value of the
   // input element already contains the type character.
-  backspace_pressed_ = (event->keyCode() == WebCore::VKEY_BACK);
+  backspace_or_delete_pressed_ = (event->keyCode() == WebCore::VKEY_BACK) ||
+                                 (event->keyCode() == WebCore::VKEY_DELETE);
 
   // The Mac code appears to use this method as a hook to implement special
   // keyboard commands specific to Safari's auto-fill implementation.  We
   // just return false to allow the default action.
   return false;
 }
 
 void EditorClientImpl::textWillBeDeletedInTextField(WebCore::Element*) {
 }
 
@@ skipping 169 matching lines @@
   }
   return L"(UNKNOWN AFFINITY)";
 }
 
 std::wstring EditorClientImpl::Describe(WebCore::CSSStyleDeclaration* style) {
   // TODO(pamg): Implement me.  It's not clear what WebKit produces for this
   // (their [style description] method), and none of the layout tests provide
   // an example.  But because none of them use it, it's not yet important.
   return std::wstring();
 }