Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 155395: GTK: Force a size on download items and elide the dangerous download filename... (Closed)

Created:
11 years, 5 months ago by Evan Stade
Modified:
9 years, 6 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_googlegroups.com, Paul Godavari, Ben Goodger (Google)
Visibility:
Public.

Description

GTK: Force a size on download items and elide the dangerous download filename. This is a temporary hack that might not work in all locales and definitely won't work if we ever let users change font sizes. GtkLabels are just plain broken. Pango is also broken because you can get height-for-width for a layout but not width-for-height. Thus we should switch to using skia to draw download items fonts, but this solution will work for now. BUG=16389 TEST=download the Dansk version of open office for windows Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20572

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chrome/browser/gtk/download_item_gtk.cc View 3 chunks +8 lines, -3 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Evan Stade
I don't even know why GtkLabels claim to support line wrapping. This code is really ...
11 years, 5 months ago (2009-07-10 23:26:39 UTC) #1
Evan Stade
ping
11 years, 5 months ago (2009-07-13 21:10:43 UTC) #2
Evan Martin
11 years, 5 months ago (2009-07-13 21:22:33 UTC) #3
LGTM

http://codereview.chromium.org/155395/diff/1/2
File chrome/browser/gtk/download_item_gtk.cc (right):

http://codereview.chromium.org/155395/diff/1/2#newcode45
Line 45: // Showing width of the dangerous file warning, in pixels.
"Showing width" is a bit of strange wording (?)

Powered by Google App Engine
This is Rietveld 408576698