Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1553833002: Display phone number with formatting in Autofill profile summary label. (Closed)

Created:
4 years, 11 months ago by Evan Stade
Modified:
4 years, 11 months ago
CC:
chromium-reviews, rouslan+autofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Display phone number with formatting in Autofill profile summary label. BUG=455318 Committed: https://crrev.com/faf5586f0cd4a403c21efc04b6827a488cfb3d4e Cr-Commit-Position: refs/heads/master@{#367382}

Patch Set 1 #

Patch Set 2 : update tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -12 lines) Patch
M components/autofill/core/browser/autofill_manager_unittest.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M components/autofill/core/browser/autofill_profile.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M components/autofill/core/browser/autofill_profile_unittest.cc View 1 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Evan Stade
4 years, 11 months ago (2015-12-31 02:13:59 UTC) #2
vabr (Chromium)
This LGTM with the failing tests fixed to document the change in intended behaviour. Cheers, ...
4 years, 11 months ago (2016-01-04 09:02:57 UTC) #4
Evan Stade
thanks. Tests updated.
4 years, 11 months ago (2016-01-04 19:05:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553833002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553833002/20001
4 years, 11 months ago (2016-01-04 19:06:12 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-04 21:53:53 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-04 21:54:53 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/faf5586f0cd4a403c21efc04b6827a488cfb3d4e
Cr-Commit-Position: refs/heads/master@{#367382}

Powered by Google App Engine
This is Rietveld 408576698