Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1868)

Issue 15538005: Patch to prevent chromium breakage until the DEPS. (Closed)

Created:
7 years, 7 months ago by scroggo
Modified:
7 years, 7 months ago
Reviewers:
djsollen
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Patch to prevent chromium breakage until the DEPS. Once https://codereview.chromium.org/15489004/ is submitted to Skia, a DEPS roll into chrome will break due to a change in the API. A long term fix for chrome to use the new API is at https://codereview.chromium.org/15496006/, but since it depends on the earlier Skia change, this patch fills in the gap. Will be reverted once https://codereview.chromium.org/15496006/ is submitted to chrome. R=djsollen@google.com Committed: https://code.google.com/p/skia/source/detail?r=9228

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
M include/core/SkPicture.h View 1 chunk +15 lines, -0 lines 0 comments Download
M src/core/SkPicture.cpp View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scroggo
7 years, 7 months ago (2013-05-21 17:54:14 UTC) #1
djsollen
lgtm
7 years, 7 months ago (2013-05-21 20:13:59 UTC) #2
scroggo
7 years, 7 months ago (2013-05-21 20:45:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r9228 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698