Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 1553663002: Only use value of chrome_public_apk_use_chromium_linker if use_chromium_linker is not set. (Closed)

Created:
4 years, 11 months ago by michaelbai
Modified:
4 years, 11 months ago
Reviewers:
Yaron, agrieve
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only use value of chrome_public_apk_use_chromium_linker if use_chromium_linker is not set. BUG=565532 TBR=yfriedman Committed: https://crrev.com/cb500879c584684e1f282977010d34a148b12814 Cr-Commit-Position: refs/heads/master@{#367173}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/android/chrome_public_apk_tmpl.gni View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
michaelbai
4 years, 11 months ago (2015-12-30 02:43:39 UTC) #3
agrieve
On 2015/12/30 02:43:39, michaelbai wrote: lgtm
4 years, 11 months ago (2015-12-30 15:04:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553663002/1
4 years, 11 months ago (2015-12-30 18:17:05 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/131986)
4 years, 11 months ago (2015-12-30 18:24:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553663002/1
4 years, 11 months ago (2015-12-30 19:32:41 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-30 19:37:25 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2015-12-30 19:38:27 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb500879c584684e1f282977010d34a148b12814
Cr-Commit-Position: refs/heads/master@{#367173}

Powered by Google App Engine
This is Rietveld 408576698