Issue 1553653002: [libplatform] allow thread_pool_size to be > 4

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1553653002: [libplatform] allow thread_pool_size to be > 4 (Closed)

Created:
4 years, 11 months ago by ofrobots

Modified:
4 years, 6 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

[libplatform] allow thread_pool_size to be > 4 The current implementation of DefaultPlaform didn't allow one to set the thread pool size to be greater than 4. With this change it is possible to set the thread pool size to be between 1 and the number of processors. R=jochen@chromium.org BUG=

Patch Set 1 #

Total comments: 1

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -5 lines)			Patch
	M	src/libplatform/default-platform.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	src/libplatform/default-platform.cc	View		2 chunks	+6 lines, -4 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

4 years, 11 months ago (2016-01-08 14:46:18 UTC) #2

https://codereview.chromium.org/1553653002/diff/1/src/libplatform/default-pla...
File src/libplatform/default-platform.cc (right):

https://codereview.chromium.org/1553653002/diff/1/src/libplatform/default-pla...
src/libplatform/default-platform.cc:74: std::max(std::min(thread_pool_size,
max_thread_pool_size_), 1);
any reason you store this in a member instead of just invoking
base::SysInfo::NumberOfProcessors() here?

note that NumberOfProcessors is actually just the number of processors online at
this point, so if your system doesn't have enough load, this might actually
restrict the thread pool size to less than four :-/

Expand Messages | Collapse Messages