Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1215)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1553623003: Port cronet_package GYP target to GN (Closed)

Created:
4 years, 11 months ago by agrieve
Modified:
4 years, 11 months ago
Reviewers:
brettw, mef
CC:
chromium-reviews, cbentzel+watch_chromium.org, pkotwicz
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Port cronet_package GYP target to GN BUG=462737 Committed: https://crrev.com/e23386b38a4086b1c92d7437f25197c57bcbf297 Cr-Commit-Position: refs/heads/master@{#367480}

Patch Set 1 #

Patch Set 2 : fix issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -2 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M build/gn_migration.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/cronet/android/BUILD.gn View 1 2 chunks +185 lines, -0 lines 0 comments Download
M components/cronet/tools/extract_from_jars.py View 1 2 chunks +5 lines, -0 lines 0 comments Download
M components/cronet/tools/generate_javadoc.py View 2 chunks +8 lines, -1 line 0 comments Download
M components/cronet/tools/jar_src.py View 2 chunks +13 lines, -1 line 0 comments Download
M url/BUILD.gn View 2 chunks +8 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1543003005 Patch 1

Messages

Total messages: 11 (5 generated)
agrieve
PS1 is pkotwicz's change PS2 shows what I tweaked. brettw - Fixed everything you pointed ...
4 years, 11 months ago (2015-12-30 20:56:00 UTC) #3
mef
LGTM, I've tried it out and got same results of cronet_package target using gyp and ...
4 years, 11 months ago (2015-12-30 21:15:46 UTC) #4
brettw
lgtm
4 years, 11 months ago (2016-01-04 22:09:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553623003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553623003/20001
4 years, 11 months ago (2016-01-05 02:52:46 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-05 04:48:06 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 04:49:53 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e23386b38a4086b1c92d7437f25197c57bcbf297
Cr-Commit-Position: refs/heads/master@{#367480}

Powered by Google App Engine
This is Rietveld 408576698