Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 1553623002: Remove random lonely semicolons. (Closed)

Created:
4 years, 11 months ago by Lei Zhang
Modified:
4 years, 11 months ago
Reviewers:
jam, Evan Stade
CC:
chromium-reviews, vmpstr+watch_chromium.org, posciak+watch_chromium.org, browser-components-watch_chromium.org, bondd+autofillwatch_chromium.org, scheib+watch_chromium.org, cbentzel+watch_chromium.org, chromoting-reviews_chromium.org, jam, tzik, yfriedman+watch_chromium.org, vabr+watchlistautofill_chromium.org, darin-cc_chromium.org, jbudorick+watch_chromium.org, mlamouri+watch-content_chromium.org, rouslan+autofill_chromium.org, nhiroki, feature-media-reviews_chromium.org, jochen+watch_chromium.org, mlamouri+watch-test-runner_chromium.org, mcasas+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, mikecase+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, klundberg+watch_chromium.org, kinuko+fileapi
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove random lonely semicolons. Committed: https://crrev.com/fd11ffe8afb5270c0714c5b456763cb19e5a67d4 Cr-Commit-Position: refs/heads/master@{#367171}

Patch Set 1 #

Patch Set 2 : fix formatting #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -210 lines) Patch
M base/numerics/safe_numerics_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_ui.cc View 1 2 chunks +137 lines, -164 lines 0 comments Download
M components/autofill/core/browser/autofill_external_delegate_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_tamper_detection_unittest.cc View 4 chunks +5 lines, -7 lines 0 comments Download
M components/message_port/web_message_port_channel_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/test_runner/event_sender.cc View 8 chunks +10 lines, -11 lines 0 comments Download
M content/renderer/media/media_stream_video_capturer_source_unittest.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M content/renderer/media/render_media_client_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M device/bluetooth/bluetooth_socket_bluez.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M media/blink/multibuffer_unittest.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M net/quic/congestion_control/cubic.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/flip_server/mem_cache.cc View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/it2me/it2me_native_messaging_host.cc View 1 chunk +1 line, -1 line 1 comment Download
M storage/browser/fileapi/file_system_usage_cache.cc View 1 chunk +0 lines, -1 line 0 comments Download
M tools/android/forwarder2/forwarder.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Lei Zhang
4 years, 11 months ago (2015-12-30 01:15:06 UTC) #2
jam
what put them there, it seems unlikely that devs did. was it an old version ...
4 years, 11 months ago (2015-12-30 16:30:44 UTC) #3
Lei Zhang
On 2015/12/30 16:30:44, jam wrote: > what put them there, it seems unlikely that devs ...
4 years, 11 months ago (2015-12-30 18:19:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553623002/20001
4 years, 11 months ago (2015-12-30 18:19:46 UTC) #6
Evan Stade
https://codereview.chromium.org/1553623002/diff/20001/remoting/host/it2me/it2me_native_messaging_host.cc File remoting/host/it2me/it2me_native_messaging_host.cc (left): https://codereview.chromium.org/1553623002/diff/20001/remoting/host/it2me/it2me_native_messaging_host.cc#oldcode284 remoting/host/it2me/it2me_native_messaging_host.cc:284: ; ha ha
4 years, 11 months ago (2015-12-30 18:49:11 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2015-12-30 19:25:58 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2015-12-30 19:27:04 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fd11ffe8afb5270c0714c5b456763cb19e5a67d4
Cr-Commit-Position: refs/heads/master@{#367171}

Powered by Google App Engine
This is Rietveld 408576698