Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1553533002: Fix android perf bot issue caused by 1550803002 (Closed)

Created:
4 years, 11 months ago by Yoland Yan(Google)
Modified:
4 years, 11 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix android perf bot issue caused by 1550803002 BUG=561190 Committed: https://crrev.com/91ed691f5bb451e7904c665e1f398c0bddd9c489 Cr-Commit-Position: refs/heads/master@{#367097}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/telemetry/telemetry/internal/platform/power_monitor/sysfs_power_monitor.py View 1 chunk +1 line, -0 lines 2 comments Download

Messages

Total messages: 11 (4 generated)
Yoland Yan(Google)
4 years, 11 months ago (2015-12-29 18:41:31 UTC) #2
dtu
lgtm
4 years, 11 months ago (2015-12-29 18:46:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553533002/1
4 years, 11 months ago (2015-12-29 18:47:12 UTC) #5
Xianzhu
https://codereview.chromium.org/1553533002/diff/1/tools/telemetry/telemetry/internal/platform/power_monitor/sysfs_power_monitor.py File tools/telemetry/telemetry/internal/platform/power_monitor/sysfs_power_monitor.py (right): https://codereview.chromium.org/1553533002/diff/1/tools/telemetry/telemetry/internal/platform/power_monitor/sysfs_power_monitor.py#newcode125 tools/telemetry/telemetry/internal/platform/power_monitor/sysfs_power_monitor.py:125: stats[cpu] = None I used another method in https://codereview.chromium.org/1547423002/ ...
4 years, 11 months ago (2015-12-29 19:37:03 UTC) #7
Yoland Yan(Google)
https://codereview.chromium.org/1553533002/diff/1/tools/telemetry/telemetry/internal/platform/power_monitor/sysfs_power_monitor.py File tools/telemetry/telemetry/internal/platform/power_monitor/sysfs_power_monitor.py (right): https://codereview.chromium.org/1553533002/diff/1/tools/telemetry/telemetry/internal/platform/power_monitor/sysfs_power_monitor.py#newcode125 tools/telemetry/telemetry/internal/platform/power_monitor/sysfs_power_monitor.py:125: stats[cpu] = None On 2015/12/29 19:37:03, Xianzhu wrote: > ...
4 years, 11 months ago (2015-12-29 19:50:49 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-29 20:08:10 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2015-12-29 20:08:52 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/91ed691f5bb451e7904c665e1f398c0bddd9c489
Cr-Commit-Position: refs/heads/master@{#367097}

Powered by Google App Engine
This is Rietveld 408576698