Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1553523002: [telemetry] Counter Cleanups (Closed)

Created:
4 years, 11 months ago by Camillo Bruni
Modified:
4 years, 10 months ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[telemetry] Counter Cleanups - remove unused counters - add "ic" prefix to all ic-counters - add more counter: maps-created, global deopts (not used yet) BUG= Committed: https://crrev.com/d037e6d6e76b6d9bcd11c33a5a3ed550c1964636 Cr-Commit-Position: refs/heads/master@{#33768}

Patch Set 1 #

Patch Set 2 : removing math_pow counter in code stubs #

Patch Set 3 : merged with master #

Patch Set 4 : fix merge conflicts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -174 lines) Patch
M src/arm/code-stubs-arm.cc View 1 2 3 chunks +0 lines, -3 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M src/builtins.cc View 1 2 3 1 chunk +11 lines, -11 lines 0 comments Download
M src/counters.h View 1 2 3 6 chunks +29 lines, -53 lines 0 comments Download
M src/heap/heap.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 3 chunks +0 lines, -3 lines 0 comments Download
M src/ic/arm/handler-compiler-arm.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/ic/arm/ic-arm.cc View 1 2 6 chunks +9 lines, -8 lines 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/ic/arm64/ic-arm64.cc View 1 2 6 chunks +8 lines, -8 lines 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ia32/ic-ia32.cc View 1 2 6 chunks +7 lines, -7 lines 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/ic/mips/ic-mips.cc View 1 2 6 chunks +9 lines, -8 lines 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/ic/mips64/ic-mips64.cc View 1 2 6 chunks +9 lines, -8 lines 0 comments Download
M src/ic/ppc/handler-compiler-ppc.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ppc/ic-ppc.cc View 1 2 6 chunks +9 lines, -8 lines 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/ic/x64/ic-x64.cc View 1 2 6 chunks +7 lines, -7 lines 0 comments Download
M src/ic/x87/handler-compiler-x87.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/ic/x87/ic-x87.cc View 1 2 6 chunks +7 lines, -7 lines 0 comments Download
M src/log.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 2 3 3 chunks +0 lines, -3 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 2 3 3 chunks +0 lines, -3 lines 0 comments Download
M src/objects.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 2 3 chunks +0 lines, -3 lines 0 comments Download
M src/runtime/runtime-maths.cc View 9 chunks +15 lines, -16 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 3 chunks +0 lines, -3 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 2 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 32 (16 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553523002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553523002/20001
4 years, 11 months ago (2015-12-29 15:27:19 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2015-12-29 15:55:31 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553523002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553523002/20001
4 years, 11 months ago (2016-01-11 08:19:47 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-11 08:52:34 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553523002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553523002/40001
4 years, 10 months ago (2016-01-29 09:46:24 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-01-29 10:59:20 UTC) #13
Igor Sheludko
lgtm
4 years, 10 months ago (2016-02-04 18:42:25 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553523002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553523002/40001
4 years, 10 months ago (2016-02-04 20:11:16 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/13269) v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, ...
4 years, 10 months ago (2016-02-04 20:12:13 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553523002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553523002/60001
4 years, 10 months ago (2016-02-05 11:44:49 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/10597)
4 years, 10 months ago (2016-02-05 11:47:50 UTC) #24
Camillo Bruni
I need heapz lgtmz plz. thanks :)
4 years, 10 months ago (2016-02-05 11:53:51 UTC) #26
Michael Lippautz
On 2016/02/05 11:53:51, cbruni wrote: > I need heapz lgtmz plz. > thanks :) heap/ ...
4 years, 10 months ago (2016-02-05 12:04:58 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553523002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553523002/60001
4 years, 10 months ago (2016-02-05 12:14:35 UTC) #29
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 10 months ago (2016-02-05 12:22:09 UTC) #30
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 12:22:55 UTC) #32
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/d037e6d6e76b6d9bcd11c33a5a3ed550c1964636
Cr-Commit-Position: refs/heads/master@{#33768}

Powered by Google App Engine
This is Rietveld 408576698