Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 15535011: Issue 10753. Fix for error column. (Closed)

Created:
7 years, 7 months ago by scheglov
Modified:
7 years, 7 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, lukeechurch_gmail.com
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/scanner/AbstractScanner.java View 1 chunk +2 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/scanner/AbstractScannerTest.java View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
7 years, 7 months ago (2013-05-21 22:31:10 UTC) #1
Brian Wilkerson
LGTM
7 years, 7 months ago (2013-05-22 02:52:32 UTC) #2
jwren
On 2013/05/22 02:52:32, Brian Wilkerson wrote: > LGTM LGTM
7 years, 7 months ago (2013-05-22 03:31:32 UTC) #3
scheglov
7 years, 7 months ago (2013-05-22 04:49:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r22979 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698