third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.cpp - Issue 1553473002: Fix SVG {text, foreignObject} transform for css animation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.cpp

Issue 1553473002: Fix SVG {text, foreignObject} transform for css animation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/svg/repaint/transform-text-element.html ('K') | « third_party/WebKit/LayoutTests/svg/repaint/transform-text-element-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.cpp

index 013d5cfc0a8307afcaaa267ee585367900894c4d..e584dd65416abfd7840a05aad6c1aa0409666e06 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.cpp

@@ -68,8 +68,11 @@ void LayoutSVGBlock::willBeDestroyed()

void LayoutSVGBlock::styleDidChange(StyleDifference diff, const ComputedStyle* oldStyle)

{

- if (diff.needsFullLayout())

+ if (diff.needsFullLayout()) {

setNeedsBoundariesUpdate();

+ if (style()->hasTransform())

+ setNeedsTransformUpdate();

+ }

if (isBlendingAllowed()) {

bool hasBlendModeChanged = (oldStyle && oldStyle->hasBlendMode()) == !style()->hasBlendMode();