third_party/WebKit/LayoutTests/svg/repaint/transform-text.html - Issue 1553473002: Fix SVG {text, foreignObject} transform for css animation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/svg/repaint/transform-text.html

Issue 1553473002: Fix SVG {text, foreignObject} transform for css animation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/svg/repaint/transform-text-expected.png » ('j') | third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../fast/repaint/resources/text-based-repaint.js"></script>

	3 <script src="../../resources/run-after-layout-and-paint.js"></script>

	4 <script>

	5 window.testIsAsync = true;

	6 window.onload = runRepaintAndPixelTest;

	7

	8 function repaintTest() {

	9 var text = document.getElementsByTagName("text")[0];

	10 ani = text.animate([{transform: 'translate(0px, 50px)'},{transform: 'translate (200px, 50px)'}], { duration: 2000, iterations: 1});
	fs 2016/01/02 16:41:13 Does this bug actually need an animation to reprod Does this bug actually need an animation to reproduce - doesn't just setting the style suffice? I.e: myTextElement.style.transform = 'translate(200px,50px)"; That would make for a simpler test, and preferbly a reftest. If this bug affects <foreignObject> too, then adding a test for that too would be good.
	11 setTimeout(function() {

	12 ani.currentTime = 1000;

	13 ani.pause();

	14 runAfterLayoutAndPaint(finishRepaintTest);

	15 }, 0);

	16 }

	17 </script>

	18 <body>

	19 <svg version="1.1" xmlns="http://www.w3.org/2000/svg">

	20 <text fill="#000000" transform="translate(0,50)">TEXT</text>

	21 </svg>

	22 </body>

OLD	NEW