third_party/WebKit/LayoutTests/svg/repaint/transform-text-element.svg - Issue 1553473002: Fix SVG {text, foreignObject} transform for css animation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/svg/repaint/transform-text-element.svg

Issue 1553473002: Fix SVG {text, foreignObject} transform for css animation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/svg/repaint/transform-foreign-object-expected.txt ('k') | third_party/WebKit/LayoutTests/svg/repaint/transform-text-element-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <svg width="400" height="400" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" onload="runRepaintTest()">

	2 <script xlink:href="../../fast/repaint/resources/text-based-repaint.js"></script >
	fs 2016/01/07 11:38:46 You should also include the resources/ahem.js scri You should also include the resources/ahem.js script here as well, to guard against flakiness.
	3 <script>

	4 <![CDATA[
	fs 2016/01/07 11:38:45 (If you make these tests HTML w/ inline SVG instea (If you make these tests HTML w/ inline SVG instead you wouldn't need this abomination/uglyness.)
	5 function repaintTest() {

	6 var text = document.getElementsByTagName("text")[0];

	7 text.style.transform = 'translate(100px, 0px)';

	8 }

	9 ]]>

	10 </script>

	11 <text x="10" y="90" font-size="100" font-family="Ahem">Test</text>
	fs 2016/01/07 11:38:45 IIRC, the "Ahem" font has an ascent of 800 (of 100 IIRC, the "Ahem" font has an ascent of 800 (of 1000 units-per-em), so using y=80 would be the more "natural choice". (You could also make this behave the same as the foreignObject test by using x=100 and make the transform cancel that out - which I find to be a good strategy. It should make for simpler to check repaint rects. It'd also be preferable to avoid clipping here - i.e either use a larger viewport or shorter text.)
	12 </svg>

OLD	NEW