Add UMA tracking for GoogleUpdate.MenuItem.InternalStorageSizeAvailable

Add UMA tracking for GoogleUpdate.MenuItem.InternalStorageSizeAvailable

BUG=566085
Committed: https://crrev.com/46b49e9e98343c42ad54cffbb77aa38bddca33a0
Cr-Commit-Position: refs/heads/master@{#367160}

[Theresa, 2015-12-28 20:23:36]

twellington@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Theresa, 2015-12-28 20:23:37]

ptal - adding tracking for InternalStorageSizeAvailable per yfriedman's request
on https://codereview.chromium.org/1531013006/

[gone, 2015-12-28 21:41:14]

lgtm % question

https://codereview.chromium.org/1553433003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/omaha/UpdateMenuItemHelper.java
(right):

https://codereview.chromium.org/1553433003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/omaha/UpdateMenuItemHelper.java:340:
"GoogleUpdate.MenuItem.InternalStorageSizeAvailable", size, 1, 200, 100);
I wonder if it makes sense to just use the old histogram, but put a note saying
that it is recorded for the menu item instead of the infobar.  What the
histogram records is more important than what it's called, and this arbitrarily
splits the data into two different locations.

What do you think?

[Theresa, 2015-12-28 21:46:42]

https://codereview.chromium.org/1553433003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/omaha/UpdateMenuItemHelper.java
(right):

https://codereview.chromium.org/1553433003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/omaha/UpdateMenuItemHelper.java:340:
"GoogleUpdate.MenuItem.InternalStorageSizeAvailable", size, 1, 200, 100);
On 2015/12/28 21:41:14, dfalcantara wrote:
> I wonder if it makes sense to just use the old histogram, but put a note
saying
> that it is recorded for the menu item instead of the infobar.  What the
> histogram records is more important than what it's called, and this
arbitrarily
> splits the data into two different locations.
> 
> What do you think?

When I try to load data for GoogleUpdate.InfoBar.InternalStorageSizeAvailable I
get "No histogram data available" (because we haven't logged it recently), so I
have a slight preference toward adding a new histogram with the MenuItem name
than repurposing the old one.

[Theresa, 2015-12-29 00:19:50]

twellington@chromium.org changed reviewers:
+ holte@chromium.org

[Theresa, 2015-12-29 00:19:50]

holte@ - ptal; adding tracking for a prexisting histogram and updating its
description in histograms.xml

https://codereview.chromium.org/1553433003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/omaha/UpdateMenuItemHelper.java
(right):

https://codereview.chromium.org/1553433003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/omaha/UpdateMenuItemHelper.java:340:
"GoogleUpdate.MenuItem.InternalStorageSizeAvailable", size, 1, 200, 100);
On 2015/12/28 21:46:42, Theresa Wellington wrote:
> On 2015/12/28 21:41:14, dfalcantara wrote:
> > I wonder if it makes sense to just use the old histogram, but put a note
> saying
> > that it is recorded for the menu item instead of the infobar.  What the
> > histogram records is more important than what it's called, and this
> arbitrarily
> > splits the data into two different locations.
> > 
> > What do you think?
> 
> When I try to load data for GoogleUpdate.InfoBar.InternalStorageSizeAvailable
I
> get "No histogram data available" (because we haven't logged it recently), so
I
> have a slight preference toward adding a new histogram with the MenuItem name
> than repurposing the old one.

As discussed offline, I changed it to reuse the InfoBar histogram.

[Steven Holte, 2015-12-30 01:17:28]

lgtm

https://codereview.chromium.org/1553433003/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1553433003/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:14798: +    device when the InfoBar or
update menu item is shown.
Does the InfoBar case actually exist anymore?  If not it's probably better to
drop mention of it here.

[Theresa, 2015-12-30 16:21:27]

On 2015/12/30 01:17:28, Steven Holte wrote:
> lgtm
> 
>
https://codereview.chromium.org/1553433003/diff/20001/tools/metrics/histogram...
> File tools/metrics/histograms/histograms.xml (right):
> 
>
https://codereview.chromium.org/1553433003/diff/20001/tools/metrics/histogram...
> tools/metrics/histograms/histograms.xml:14798: +    device when the InfoBar or
> update menu item is shown.
> Does the InfoBar case actually exist anymore?  If not it's probably better to
> drop mention of it here.

The InfoBar may be get reintroduced in older versions of Chrome (it's disabled
server side), so this histogram may be for both.

[Theresa, 2015-12-30 16:21:34]

The CQ bit was checked by twellington@chromium.org

[Theresa, 2015-12-30 16:21:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/1553433003/#ps20001
(title: "Reuse GoogleUpdate.InfoBar histogram")

[commit-bot: I haz the power, 2015-12-30 16:22:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1553433003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1553433003/20001

[commit-bot: I haz the power, 2015-12-30 17:33:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-30 17:34:42]

Description was changed from

==========
Add UMA tracking for GoogleUpdate.MenuItem.InternalStorageSizeAvailable

BUG=566085
==========

to

==========
Add UMA tracking for GoogleUpdate.MenuItem.InternalStorageSizeAvailable

BUG=566085

Committed: https://crrev.com/46b49e9e98343c42ad54cffbb77aa38bddca33a0
Cr-Commit-Position: refs/heads/master@{#367160}
==========

[commit-bot: I haz the power, 2015-12-30 17:34:43]

Patchset 2 (id:??) landed as
https://crrev.com/46b49e9e98343c42ad54cffbb77aa38bddca33a0
Cr-Commit-Position: refs/heads/master@{#367160}

[Yaron, 2016-01-04 14:37:24]

yfriedman@chromium.org changed reviewers:
+ yfriedman@chromium.org

[Yaron, 2016-01-04 14:37:24]

https://codereview.chromium.org/1553433003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/omaha/UpdateMenuItemHelper.java
(right):

https://codereview.chromium.org/1553433003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/omaha/UpdateMenuItemHelper.java:121:
recordInternalStorageSize();
nit: you were already in an asynctask so it's not really necessary to fire
another one

[Theresa, 2016-01-04 21:02:29]

https://codereview.chromium.org/1553433003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/omaha/UpdateMenuItemHelper.java
(right):

https://codereview.chromium.org/1553433003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/omaha/UpdateMenuItemHelper.java:121:
recordInternalStorageSize();
On 2016/01/04 14:37:24, Yaron wrote:
> nit: you were already in an asynctask so it's not really necessary to fire
> another one

Great point. I'll fix that in a follow up CL.