sync/internal_api/syncapi_server_connection_manager.cc - Issue 1553433002: [Sync] Sync should run canary cycle after any network related error

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/syncapi_server_connection_manager.cc

Issue 1553433002: [Sync] Sync should run canary cycle after any network related error (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adjust initial delay for CONNECTION_UNAVAILABLE error. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sync/internal_api/syncapi_server_connection_manager.h ('k') | sync/internal_api/syncapi_server_connection_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sync/internal_api/syncapi_server_connection_manager.cc

diff --git a/sync/internal_api/syncapi_server_connection_manager.cc b/sync/internal_api/syncapi_server_connection_manager.cc

index 16646ec7f4df4ee93cbb979c7d8b371b072422e8..33bfba26fb5b78974a8e8316b4fbcb56c79bf025 100644

--- a/sync/internal_api/syncapi_server_connection_manager.cc

+++ b/sync/internal_api/syncapi_server_connection_manager.cc

@@ -53,9 +53,9 @@ bool SyncAPIBridgedConnection::Init(const char* path,

int error_code = 0;

int response_code = 0;

if (!http->MakeSynchronousPost(&error_code, &response_code)) {

+ DCHECK(error_code != net::OK);

Nicolas Zea 2015/12/30 21:34:34 DCHECK_NE?

pavely 2016/01/04 23:31:04 Done.

DVLOG(1) << "Http POST failed, error returns: " << error_code;

- response->server_status = HttpResponse::ServerConnectionCodeFromNetError(

- error_code);

+ response->server_status = HttpResponse::CONNECTION_UNAVAILABLE;

return false;

}