Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: third_party/re2/BUILD.gn

Issue 1553403002: re2: Drop dynamic_annotations dependency and remove compiler warning flags (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/re2/re2.gyp » ('j') | third_party/re2/re2.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/re2/BUILD.gn
diff --git a/third_party/re2/BUILD.gn b/third_party/re2/BUILD.gn
index 3777b6d96eb0e0b17bd3d5aa96f68fac16fd95e3..b827d59d12bd2c1dd72b49c63f5d49eaac37318a 100644
--- a/third_party/re2/BUILD.gn
+++ b/third_party/re2/BUILD.gn
@@ -61,17 +61,6 @@ static_library("re2") {
configs += [ "//build/config/compiler:no_chromium_code" ]
public_configs = [ ":re2_config" ]
- deps = [
- "//base/third_party/dynamic_annotations",
- ]
-
- if (is_win) {
- cflags = [
- "/wd4018", # Signed/unsigned mismatch in comparison.
- "/wd4722", # Destructor never terminates.
- ]
- }
-
# TODO(battre) If Dr. Memory is ever migrated to GN, a flag needs to be
# added for this that adds a MEMORY_SANITIZER define. See re2.gyp.
# if (is_drmemory) {
« no previous file with comments | « no previous file | third_party/re2/re2.gyp » ('j') | third_party/re2/re2.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698