re2: Drop dynamic_annotations dependency and remove compiler warning flags

third_party/re2/re2.gyp

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'build_for_tool%': '',

[tfarina, 2016/01/05 16:50:21]

what is this for? Can we get rid of it?

[battre, 2016/01/05 16:56:08]

This is needed. It declares build_for_tool as a variable that is empty by
default but can be overridden.

Without this line, 'build_for_tool=="drmemory"' would fail if you don't set the
variable.

   },
   'targets': [
     {
       'target_name': 're2',
       'type': 'static_library',
       'include_dirs': [

[tfarina, 2016/01/05 16:50:21]

is this and direct_dependent_settings really needed?

[battre, 2016/01/05 16:56:08]

hm, no idea.

         'src',
         '<(DEPTH)',
       ],
       'direct_dependent_settings': {
         'include_dirs': [
           'src',
           '<(DEPTH)',
         ],
       },
-      'dependencies': [
-        '<(DEPTH)/base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
-      ],
       'sources': [
         'src/re2/bitstate.cc',
         'src/re2/compile.cc',
         'src/re2/dfa.cc',
         'src/re2/filtered_re2.cc',
         'src/re2/filtered_re2.h',
         'src/re2/mimics_pcre.cc',
         'src/re2/nfa.cc',
         'src/re2/onepass.cc',
         'src/re2/parse.cc',
@@ skipping 30 matching lines @@
         'src/util/sparse_array.h',
         'src/util/sparse_set.h',
         'src/util/stringprintf.cc',
         'src/util/strutil.cc',
         'src/util/utf.h',
         'src/util/util.h',
         'src/util/valgrind.cc',
         'src/util/valgrind.h',
       ],
       'conditions': [
-        ['OS=="win"', {
-          'msvs_disabled_warnings': [ 4018, 4722, 4267 ],
-        }],
         ['build_for_tool=="drmemory"', {
           # Treat builds for Dr. Memory as builds for MSAN to prevent false
           # positives created by lazily initialized memory.
           # See crbug.com/568119#3 .
           'defines': [
             'MEMORY_SANITIZER'
           ],
         }],
       ]
     },
   ],
 }