re2: Drop dynamic_annotations dependency and remove compiler warning flags

re2: Drop dynamic_annotations dependency and remove compiler warning flags

This CL removes some build file specifications that are not needed anymore.

BUG=568119
Committed: https://crrev.com/c1aa567aeb8343b60d832973a024678dcb8a86c6
Cr-Commit-Position: refs/heads/master@{#367539}

[battre, 2016-01-05 13:28:59]

battre@chromium.org changed reviewers:
+ thakis@chromium.org

[battre, 2016-01-05 13:28:59]

Hi Nico,

could you please review this CL?

Thanks,
Dominic

[Nico, 2016-01-05 15:54:00]

Description was changed from

==========
Drop dynamic_annotations dependency and remove compiler warning flags

This CL removes some build file specifications that are not needed anymore.

BUG=568119
==========

to

==========
re2: Drop dynamic_annotations dependency and remove compiler warning flags

This CL removes some build file specifications that are not needed anymore.

BUG=568119
==========

[Nico, 2016-01-05 15:55:14]

lgtm, thanks.

I prefixed the subject line of your cl description with "re2:".

[Nico, 2016-01-05 15:55:22]

The CQ bit was checked by thakis@chromium.org

[Nico, 2016-01-05 15:55:32]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-01-05 15:56:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1553403002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1553403002/1

[commit-bot: I haz the power, 2016-01-05 16:00:26]

Description was changed from

==========
re2: Drop dynamic_annotations dependency and remove compiler warning flags

This CL removes some build file specifications that are not needed anymore.

BUG=568119
==========

to

==========
re2: Drop dynamic_annotations dependency and remove compiler warning flags

This CL removes some build file specifications that are not needed anymore.

BUG=568119
==========

[commit-bot: I haz the power, 2016-01-05 16:00:27]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-05 16:01:23]

Description was changed from

==========
re2: Drop dynamic_annotations dependency and remove compiler warning flags

This CL removes some build file specifications that are not needed anymore.

BUG=568119
==========

to

==========
re2: Drop dynamic_annotations dependency and remove compiler warning flags

This CL removes some build file specifications that are not needed anymore.

BUG=568119

Committed: https://crrev.com/c1aa567aeb8343b60d832973a024678dcb8a86c6
Cr-Commit-Position: refs/heads/master@{#367539}
==========

[commit-bot: I haz the power, 2016-01-05 16:01:23]

Patchset 1 (id:??) landed as
https://crrev.com/c1aa567aeb8343b60d832973a024678dcb8a86c6
Cr-Commit-Position: refs/heads/master@{#367539}

[tfarina, 2016-01-05 16:50:20]

tfarina@chromium.org changed reviewers:
+ tfarina@chromium.org

[tfarina, 2016-01-05 16:50:21]

lgtm, thanks!

https://codereview.chromium.org/1553403002/diff/1/third_party/re2/re2.gyp
File third_party/re2/re2.gyp (right):

https://codereview.chromium.org/1553403002/diff/1/third_party/re2/re2.gyp#new...
third_party/re2/re2.gyp:7: 'build_for_tool%': '',
what is this for? Can we get rid of it?

https://codereview.chromium.org/1553403002/diff/1/third_party/re2/re2.gyp#new...
third_party/re2/re2.gyp:13: 'include_dirs': [
is this and direct_dependent_settings really needed?

[battre, 2016-01-05 16:56:08]

https://codereview.chromium.org/1553403002/diff/1/third_party/re2/re2.gyp
File third_party/re2/re2.gyp (right):

https://codereview.chromium.org/1553403002/diff/1/third_party/re2/re2.gyp#new...
third_party/re2/re2.gyp:7: 'build_for_tool%': '',
On 2016/01/05 16:50:21, tfarina wrote:
> what is this for? Can we get rid of it?

This is needed. It declares build_for_tool as a variable that is empty by
default but can be overridden.

Without this line, 'build_for_tool=="drmemory"' would fail if you don't set the
variable.

https://codereview.chromium.org/1553403002/diff/1/third_party/re2/re2.gyp#new...
third_party/re2/re2.gyp:13: 'include_dirs': [
On 2016/01/05 16:50:21, tfarina wrote:
> is this and direct_dependent_settings really needed?

hm, no idea.