Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1553363002: Move miscellaneous properties into CSSPropertyParser (Closed)

Created:
4 years, 11 months ago by rwlbuis
Modified:
4 years, 11 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move miscellaneous properties into CSSPropertyParser Move the following properties from LegacyCSSPropertyParser into CSSPropertyParser: - order - opacity - text-underline-position - vertical-align - -webkit-box-flex - -webkit-box-flex-group BUG=499780 Committed: https://crrev.com/cbfa710545a06ce896e3cb1557dfa247f4597724 Cr-Commit-Position: refs/heads/master@{#370016}

Patch Set 1 #

Patch Set 2 : V2 #

Patch Set 3 : V3 #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -30 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 2 3 7 chunks +30 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp View 1 2 3 5 chunks +6 lines, -27 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
rwlbuis
PTAL.
4 years, 11 months ago (2016-01-18 02:46:52 UTC) #3
Timothy Loh
mmk lgtm
4 years, 11 months ago (2016-01-18 05:06:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553363002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553363002/60001
4 years, 11 months ago (2016-01-18 11:55:45 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 11 months ago (2016-01-18 13:03:26 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-18 13:04:12 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/cbfa710545a06ce896e3cb1557dfa247f4597724
Cr-Commit-Position: refs/heads/master@{#370016}

Powered by Google App Engine
This is Rietveld 408576698