Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 155333002: Broaden suppressions of probably-intentional leaks in AppKit. (Closed)

Created:
6 years, 10 months ago by Jeffrey Yasskin
Modified:
6 years, 10 months ago
Reviewers:
tapted
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

Broaden suppressions of probably-intentional leaks in AppKit. This reappeared in http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Mac%20%28valgrind%29%281%29/builds/25830, but none of the CLs in that blamelist look likely. It's probably a change in test randomization and/or bot configuration. BUG=105525, 257276, 340847 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248846

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix tapted's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -24 lines) Patch
M tools/valgrind/memcheck/suppressions_mac.txt View 1 2 chunks +2 lines, -24 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Jeffrey Yasskin
6 years, 10 months ago (2014-02-05 00:26:01 UTC) #1
tapted
lgtm I think this is reasonable. An explanation for the "why it appears now" could ...
6 years, 10 months ago (2014-02-05 00:35:37 UTC) #2
Jeffrey Yasskin
On 2014/02/05 00:35:37, tapted wrote: > I think this is reasonable. An explanation for the ...
6 years, 10 months ago (2014-02-05 00:45:44 UTC) #3
Jeffrey Yasskin
The CQ bit was checked by jyasskin@chromium.org
6 years, 10 months ago (2014-02-05 01:06:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/155333002/60001
6 years, 10 months ago (2014-02-05 03:53:51 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 04:24:43 UTC) #6
Message was sent while issue was closed.
Change committed as 248846

Powered by Google App Engine
This is Rietveld 408576698