Liveness analysis for environment slots in Hydrogen

test/mjsunit/debug-evaluate-locals-optimized-double.js

Index: test/mjsunit/debug-evaluate-locals-optimized-double.js
diff --git a/test/mjsunit/debug-evaluate-locals-optimized-double.js b/test/mjsunit/debug-evaluate-locals-optimized-double.js
index 8d91b973ce9562b97fedb503af29cf0987b76984..6696ec5ecd0651219fcff561ce9467c0ca860d86 100644
--- a/test/mjsunit/debug-evaluate-locals-optimized-double.js
+++ b/test/mjsunit/debug-evaluate-locals-optimized-double.js
@@ -185,6 +185,7 @@ function h(i, x0, y0) {
   a0 = a0 + a0 / 100;
   b0 = b0 + b0 / 100;
   debugger;  // Breakpoint.

[titzer, 2013/05/29 16:58:05]

Not sure why we are changing these tests. Does something break with debugging?

[Jakob Kummerow, 2013/06/03 17:50:38]

We need to extend the live ranges of the values that are being inspected beyond
the point where they are inspected. The "debugger;" statement triggers the big
"listener()" function above (lines 65ff.), which has expectations for the local
variables in every stack frame.

This does mean that users inspecting stack frames where local values have been
zapped at the end of their live range will see "undefined" unexpectedly.
Unfortunately, there's nothing we can do to prevent that, because there's no way
to predict if/when a stack frame will be inspected.

+  return a0 + b0;
 };
 
 function g3(i, x1, y1) {
@@ -193,7 +194,7 @@ function g3(i, x1, y1) {
   a1 = a1 + a1 / 100;
   b1 = b1 + b1 / 100;
   h(i - 1, a1, b1);
-  return a1+b1;
+  return a1 + b1;
 };
 
 function g2(i) {
@@ -202,6 +203,7 @@ function g2(i) {
   a2 = a2 + a2 / 100;
   b2 = b2 + b2 / 100;
   g3(i - 1, a2, b2);
+  return a2 + b2;
 };
 
 function g1(i, x3, y3, z3) {
@@ -210,6 +212,7 @@ function g1(i, x3, y3, z3) {
   a3 = a3 + a3 / 100;
   b3 = b3 + b3 / 100;
   new g2(i - 1, a3, b3);
+  return a3 + b3;
 };
 
 function f(i, x4, y4) {
@@ -218,6 +221,7 @@ function f(i, x4, y4) {
   a4 = a4 + a4 / 100;
   b4 = b4 + b4 / 100;
   g1(i - 1, a4, b4);
+  return a4 + b4;
 };
 
 // Test calling f normally and as a constructor.